threads / discuss / 48578

2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

Subject: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

## tl;dr

3 messages between May 26, 2018 and May 27, 2018.

replies: 2people: 2as markdown or json

Jeff Felchner· May 26, 2018, 20:45 UTC · lore

Ever since 2.17.0, when saving a patch (using add --patch but probably other ways as well), if the whitespace is removed from the initial column, the patch doesn't apply.

Full walkthrough (including comparison with 2.16.3) in the video attached to this link:

https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1

Todd Zullinger· May 26, 2018, 21:07 UTC · re: Jeff Felchner · lore

Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

Hi Jeff,

Jeff Felchner wrote:

> Ever since 2.17.0, when saving a patch (using add --patch
> but probably other ways as well), if the whitespace is
> removed from the initial column, the patch doesn't apply.

This sounds a bit like the issue discussed in this thread a few weeks ago:

https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/

But I didn't download or watch the video, so I'm not positive.

> Full walkthrough (including comparison with 2.16.3) in the
> video attached to this link:
> 
> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Everybody knows how to raise children, except the people who have
them.
    -- P.J. O'Rourke

Jeff Felchner· May 27, 2018, 04:16 UTC · re: Todd Zullinger · lore

Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column

Todd, it looks like that may very well be the same issue.  And it looks like it's planning on being fixed in the next release?  Would that be 2.17.1 since it's a regression?

Show 28 quoted lines

> On 2018 May 26, at 16:07, Todd Zullinger <tmz@pobox.com> wrote:
> 
> Hi Jeff,
> 
> Jeff Felchner wrote:
>> Ever since 2.17.0, when saving a patch (using add --patch
>> but probably other ways as well), if the whitespace is
>> removed from the initial column, the patch doesn't apply.
> 
> This sounds a bit like the issue discussed in this thread a
> few weeks ago:
> 
> https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/
> 
> But I didn't download or watch the video, so I'm not positive.
> 
>> Full walkthrough (including comparison with 2.16.3) in the
>> video attached to this link:
>> 
>> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1
> 
> -- 
> Todd
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Everybody knows how to raise children, except the people who have
> them.
>    -- P.J. O'Rourke
>