# 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column 3 messages from 2018-05-26 to 2018-05-27. Participants: Jeff Felchner, Todd Zullinger. Thread: https://gitlist.dev/t/48578 ## Jeff Felchner, 2018-05-26 20:45 Subject: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column Message-ID: URL: https://gitlist.dev/e/C6CF9BE4-FC46-4B39-A862-AEBB5CD600E2%40gmail.com ``` Ever since 2.17.0, when saving a patch (using add --patch but probably other ways as well), if the whitespace is removed from the initial column, the patch doesn't apply. Full walkthrough (including comparison with 2.16.3) in the video attached to this link: https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1 ``` ## Todd Zullinger, 2018-05-26 21:07 Subject: Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column Message-ID: <20180526210752.GA3094@zaya.teonanacatl.net> URL: https://gitlist.dev/e/20180526210752.GA3094%40zaya.teonanacatl.net In-Reply-To: ``` Hi Jeff, Jeff Felchner wrote: > Ever since 2.17.0, when saving a patch (using add --patch > but probably other ways as well), if the whitespace is > removed from the initial column, the patch doesn't apply. This sounds a bit like the issue discussed in this thread a few weeks ago: https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/ But I didn't download or watch the video, so I'm not positive. > Full walkthrough (including comparison with 2.16.3) in the > video attached to this link: > > https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1 -- Todd ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Everybody knows how to raise children, except the people who have them. -- P.J. O'Rourke ``` ## Jeff Felchner, 2018-05-27 04:16 Subject: Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column Message-ID: URL: https://gitlist.dev/e/F8B7F3D0-E0C3-4E11-92EC-567BEDF19037%40gmail.com In-Reply-To: <20180526210752.GA3094@zaya.teonanacatl.net> ``` Todd, it looks like that may very well be the same issue. And it looks like it's planning on being fixed in the next release? Would that be 2.17.1 since it's a regression? > On 2018 May 26, at 16:07, Todd Zullinger wrote: > > Hi Jeff, > > Jeff Felchner wrote: >> Ever since 2.17.0, when saving a patch (using add --patch >> but probably other ways as well), if the whitespace is >> removed from the initial column, the patch doesn't apply. > > This sounds a bit like the issue discussed in this thread a > few weeks ago: > > https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/ > > But I didn't download or watch the video, so I'm not positive. > >> Full walkthrough (including comparison with 2.16.3) in the >> video attached to this link: >> >> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1 > > -- > Todd > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Everybody knows how to raise children, except the people who have > them. > -- P.J. O'Rourke > ```