{"thread":{"id":"48578","subject":"2.17.0 Regression When Adding Patches Without Whitespace In Initial Column","startedAt":"2018-05-26T20:45:48Z","lastAt":"2018-05-27T04:16:09Z","messageCount":3,"participants":["Jeff Felchner","Todd Zullinger"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"348608","messageId":"C6CF9BE4-FC46-4B39-A862-AEBB5CD600E2@gmail.com","threadId":"48578","inReplyTo":null,"subject":"2.17.0 Regression When Adding Patches Without Whitespace In Initial Column","fromName":"Jeff Felchner","fromEmail":"jfelchner1@gmail.com","sentAt":"2018-05-26T20:45:42Z","receivedAt":"2018-05-26T20:45:48Z","isPatch":false,"sender":{"key":"jfelchner1@gmail.com","avatar":null},"body":"Ever since 2.17.0, when saving a patch (using add --patch but probably other ways as well), if the whitespace is removed from the initial column, the patch doesn't apply.\n\nFull walkthrough (including comparison with 2.16.3) in the video attached to this link:\n\nhttps://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1"},{"id":"348609","messageId":"20180526210752.GA3094@zaya.teonanacatl.net","threadId":"48578","inReplyTo":"C6CF9BE4-FC46-4B39-A862-AEBB5CD600E2@gmail.com","subject":"Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-05-26T21:07:52Z","receivedAt":"2018-05-26T21:07:58Z","isPatch":false,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi Jeff,\n\nJeff Felchner wrote:\n> Ever since 2.17.0, when saving a patch (using add --patch\n> but probably other ways as well), if the whitespace is\n> removed from the initial column, the patch doesn't apply.\n\nThis sounds a bit like the issue discussed in this thread a\nfew weeks ago:\n\nhttps://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/\n\nBut I didn't download or watch the video, so I'm not positive.\n\n> Full walkthrough (including comparison with 2.16.3) in the\n> video attached to this link:\n> \n> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nEverybody knows how to raise children, except the people who have\nthem.\n    -- P.J. O'Rourke\n\n"},{"id":"348615","messageId":"F8B7F3D0-E0C3-4E11-92EC-567BEDF19037@gmail.com","threadId":"48578","inReplyTo":"20180526210752.GA3094@zaya.teonanacatl.net","subject":"Re: 2.17.0 Regression When Adding Patches Without Whitespace In Initial Column","fromName":"Jeff Felchner","fromEmail":"jfelchner1@gmail.com","sentAt":"2018-05-27T04:16:01Z","receivedAt":"2018-05-27T04:16:09Z","isPatch":false,"sender":{"key":"jfelchner1@gmail.com","avatar":null},"body":"Todd, it looks like that may very well be the same issue.  And it looks like it's planning on being fixed in the next release?  Would that be 2.17.1 since it's a regression?\n\n> On 2018 May 26, at 16:07, Todd Zullinger <tmz@pobox.com> wrote:\n> \n> Hi Jeff,\n> \n> Jeff Felchner wrote:\n>> Ever since 2.17.0, when saving a patch (using add --patch\n>> but probably other ways as well), if the whitespace is\n>> removed from the initial column, the patch doesn't apply.\n> \n> This sounds a bit like the issue discussed in this thread a\n> few weeks ago:\n> \n> https://public-inbox.org/git/e8aedc6b-5b3e-cfb2-be9d-971bfd9adde8@talktalk.net/\n> \n> But I didn't download or watch the video, so I'm not positive.\n> \n>> Full walkthrough (including comparison with 2.16.3) in the\n>> video attached to this link:\n>> \n>> https://www.dropbox.com/s/s1ophi4mwmf9ogv/git-add-patch-whitespace-bug.mp4?dl=1\n> \n> -- \n> Todd\n> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n> Everybody knows how to raise children, except the people who have\n> them.\n>    -- P.J. O'Rourke\n> \n\n"}]}