threads / patch / 48550

patchconfig: document value 2 for protocol.version

Subject: [PATCH] config: document value 2 for protocol.version

## tl;dr

5 messages between May 22, 2018 and Sep 10, 2018. Diffs are folded; open one to read it.

replies: 4people: 4as markdown or json

Brandon Williams· May 22, 2018, 22:27 UTC · lore

Update the config documentation to note the value `2` as an acceptable value for the protocol.version config.

Signed-off-by: Brandon Williams <bmwill@google.com>
---
 Documentation/config.txt | 2 ++
 1 file changed, 2 insertions(+)
Show changes to Documentation/config.txt +2 −0
diff --git a/Documentation/config.txt b/Documentation/config.txt
index a05a88fec..ce778883d 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -2637,6 +2637,8 @@ protocol.version::
 * `1` - the original wire protocol with the addition of a version string
   in the initial response from the server.
 
+* `2` - wire protocol version 2.
+
 --
 
 pull.ff::

-- 
2.17.0.441.gb46fe60e1d-goog
Jonathan Nieder· May 22, 2018, 22:32 UTC · re: Brandon Williams · lore

Re: [PATCH] config: document value 2 for protocol.version

Brandon Williams wrote:
Show 7 quoted lines
> Update the config documentation to note the value `2` as an acceptable
> value for the protocol.version config.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
>  Documentation/config.txt | 2 ++
>  1 file changed, 2 insertions(+)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Show 11 quoted lines
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index a05a88fec..ce778883d 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2637,6 +2637,8 @@ protocol.version::
>  * `1` - the original wire protocol with the addition of a version string
>    in the initial response from the server.
>  
> +* `2` - wire protocol version 2.
> +
>  --

Should this mention where the user can find more details (e.g. by saying link:technical/protocol-v2.html[protocol version 2])?

See the reference to the credentials API in "git help credentials" for an example of how that renders.

Jonathan
Josh Steadmon· Sep 10, 2018, 21:21 UTC · re: Jonathan Nieder · lore

[PATCH v2] config: document value 2 for protocol.version

From: Brandon Williams <bmwill@google.com>

Update the config documentation to note the value `2` as an acceptable value for the protocol.version config.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Josh Steadmon <steadmon@google.com>
---
 Documentation/config.txt | 2 ++
 1 file changed, 2 insertions(+)
Show changes to Documentation/config.txt +2 −0
diff --git a/Documentation/config.txt b/Documentation/config.txt
index eb66a1197..ee3b5dd8e 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -2828,6 +2828,8 @@ protocol.version::
 * `1` - the original wire protocol with the addition of a version string
   in the initial response from the server.
 
+* `2` - link:technical/protocol-v2.html[wire protocol version 2].
+
 --
 
 pull.ff::

-- 
2.19.0.rc2.392.g5ba43deb5a-goog
Jonathan Nieder· Sep 10, 2018, 21:30 UTC · re: Josh Steadmon · lore

Re: [PATCH v2] config: document value 2 for protocol.version

Josh Steadmon wrote:
Show 10 quoted lines
> From: Brandon Williams <bmwill@google.com>
>
> Update the config documentation to note the value `2` as an acceptable
> value for the protocol.version config.
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> Signed-off-by: Josh Steadmon <steadmon@google.com>
> ---
>  Documentation/config.txt | 2 ++
>  1 file changed, 2 insertions(+)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Junio C Hamano· Sep 10, 2018, 22:00 UTC · re: Jonathan Nieder · lore

Re: [PATCH v2] config: document value 2 for protocol.version

Jonathan Nieder <jrnieder@gmail.com> writes:
Show 16 quoted lines
> Josh Steadmon wrote:
>
>> From: Brandon Williams <bmwill@google.com>
>>
>> Update the config documentation to note the value `2` as an acceptable
>> value for the protocol.version config.
>>
>> Signed-off-by: Brandon Williams <bmwill@google.com>
>> Signed-off-by: Josh Steadmon <steadmon@google.com>
>> ---
>>  Documentation/config.txt | 2 ++
>>  1 file changed, 2 insertions(+)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Thanks.
Thanks.

← back to recent threads