# [PATCH] config: document value 2 for protocol.version 5 messages from 2018-05-22 to 2018-09-10. Participants: Brandon Williams, Jonathan Nieder, Josh Steadmon, Junio C Hamano. Thread: https://gitlist.dev/t/48550 ## Brandon Williams, 2018-05-22 22:27 Subject: [PATCH] config: document value 2 for protocol.version Message-ID: <20180522222718.81173-1-bmwill@google.com> URL: https://gitlist.dev/e/20180522222718.81173-1-bmwill%40google.com ``` Update the config documentation to note the value `2` as an acceptable value for the protocol.version config. Signed-off-by: Brandon Williams --- Documentation/config.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index a05a88fec..ce778883d 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2637,6 +2637,8 @@ protocol.version:: * `1` - the original wire protocol with the addition of a version string in the initial response from the server. +* `2` - wire protocol version 2. + -- pull.ff:: -- 2.17.0.441.gb46fe60e1d-goog ``` ## Jonathan Nieder, 2018-05-22 22:32 Subject: Re: [PATCH] config: document value 2 for protocol.version Message-ID: <20180522223208.GQ10623@aiede.svl.corp.google.com> URL: https://gitlist.dev/e/20180522223208.GQ10623%40aiede.svl.corp.google.com In-Reply-To: <20180522222718.81173-1-bmwill@google.com> ``` Brandon Williams wrote: > Update the config documentation to note the value `2` as an acceptable > value for the protocol.version config. > > Signed-off-by: Brandon Williams > --- > Documentation/config.txt | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Jonathan Nieder Thanks. > diff --git a/Documentation/config.txt b/Documentation/config.txt > index a05a88fec..ce778883d 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -2637,6 +2637,8 @@ protocol.version:: > * `1` - the original wire protocol with the addition of a version string > in the initial response from the server. > > +* `2` - wire protocol version 2. > + > -- Should this mention where the user can find more details (e.g. by saying link:technical/protocol-v2.html[protocol version 2])? See the reference to the credentials API in "git help credentials" for an example of how that renders. Jonathan ``` ## Josh Steadmon, 2018-09-10 21:21 Subject: [PATCH v2] config: document value 2 for protocol.version Message-ID: <20180910212157.134291-1-steadmon@google.com> URL: https://gitlist.dev/e/20180910212157.134291-1-steadmon%40google.com In-Reply-To: <20180522223208.GQ10623@aiede.svl.corp.google.com> ``` From: Brandon Williams Update the config documentation to note the value `2` as an acceptable value for the protocol.version config. Signed-off-by: Brandon Williams Signed-off-by: Josh Steadmon --- Documentation/config.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index eb66a1197..ee3b5dd8e 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2828,6 +2828,8 @@ protocol.version:: * `1` - the original wire protocol with the addition of a version string in the initial response from the server. +* `2` - link:technical/protocol-v2.html[wire protocol version 2]. + -- pull.ff:: -- 2.19.0.rc2.392.g5ba43deb5a-goog ``` ## Jonathan Nieder, 2018-09-10 21:30 Subject: Re: [PATCH v2] config: document value 2 for protocol.version Message-ID: <20180910213006.GH26356@aiede.svl.corp.google.com> URL: https://gitlist.dev/e/20180910213006.GH26356%40aiede.svl.corp.google.com In-Reply-To: <20180910212157.134291-1-steadmon@google.com> ``` Josh Steadmon wrote: > From: Brandon Williams > > Update the config documentation to note the value `2` as an acceptable > value for the protocol.version config. > > Signed-off-by: Brandon Williams > Signed-off-by: Josh Steadmon > --- > Documentation/config.txt | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Jonathan Nieder Thanks. ``` ## Junio C Hamano, 2018-09-10 22:00 Subject: Re: [PATCH v2] config: document value 2 for protocol.version Message-ID: URL: https://gitlist.dev/e/xmqq7ejtrp1i.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20180910213006.GH26356@aiede.svl.corp.google.com> ``` Jonathan Nieder writes: > Josh Steadmon wrote: > >> From: Brandon Williams >> >> Update the config documentation to note the value `2` as an acceptable >> value for the protocol.version config. >> >> Signed-off-by: Brandon Williams >> Signed-off-by: Josh Steadmon >> --- >> Documentation/config.txt | 2 ++ >> 1 file changed, 2 insertions(+) > > Reviewed-by: Jonathan Nieder > > Thanks. Thanks. ```