{"thread":{"id":"48550","subject":"[PATCH] config: document value 2 for protocol.version","startedAt":"2018-05-22T22:27:27Z","lastAt":"2018-09-10T22:00:30Z","messageCount":5,"participants":["Brandon Williams","Jonathan Nieder","Josh Steadmon","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"348334","messageId":"20180522222718.81173-1-bmwill@google.com","threadId":"48550","inReplyTo":null,"subject":"[PATCH] config: document value 2 for protocol.version","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2018-05-22T22:27:18Z","receivedAt":"2018-05-22T22:27:27Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"Update the config documentation to note the value `2` as an acceptable\nvalue for the protocol.version config.\n\nSigned-off-by: Brandon Williams \n---\n Documentation/config.txt | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex a05a88fec..ce778883d 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -2637,6 +2637,8 @@ protocol.version::\n * `1` - the original wire protocol with the addition of a version string\n in the initial response from the server.\n \n+* `2` - wire protocol version 2.\n+\n --\n \n pull.ff::\n-- \n2.17.0.441.gb46fe60e1d-goog\n\n"},{"id":"348336","messageId":"20180522223208.GQ10623@aiede.svl.corp.google.com","threadId":"48550","inReplyTo":"20180522222718.81173-1-bmwill@google.com","subject":"Re: [PATCH] config: document value 2 for protocol.version","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-05-22T22:32:08Z","receivedAt":"2018-05-22T22:32:14Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Brandon Williams wrote:\n\n> Update the config documentation to note the value `2` as an acceptable\n> value for the protocol.version config.\n>\n> Signed-off-by: Brandon Williams \n> ---\n> Documentation/config.txt | 2 ++\n> 1 file changed, 2 insertions(+)\n\nReviewed-by: Jonathan Nieder \n\nThanks.\n\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index a05a88fec..ce778883d 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -2637,6 +2637,8 @@ protocol.version::\n> * `1` - the original wire protocol with the addition of a version string\n> in the initial response from the server.\n> \n> +* `2` - wire protocol version 2.\n> +\n> --\n\nShould this mention where the user can find more details (e.g. by\nsaying link:technical/protocol-v2.html[protocol version 2])?\n\nSee the reference to the credentials API in \"git help credentials\" for\nan example of how that renders.\n\nJonathan\n"},{"id":"357831","messageId":"20180910212157.134291-1-steadmon@google.com","threadId":"48550","inReplyTo":"20180522223208.GQ10623@aiede.svl.corp.google.com","subject":"[PATCH v2] config: document value 2 for protocol.version","fromName":"Josh Steadmon","fromEmail":"steadmon@google.com","sentAt":"2018-09-10T21:21:57Z","receivedAt":"2018-09-10T21:22:18Z","isPatch":true,"sender":{"key":"steadmon@google.com","avatar":"https://avatars.githubusercontent.com/u/2654920?v=4"},"body":"From: Brandon Williams \n\nUpdate the config documentation to note the value `2` as an acceptable\nvalue for the protocol.version config.\n\nSigned-off-by: Brandon Williams \nSigned-off-by: Josh Steadmon \n---\n Documentation/config.txt | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex eb66a1197..ee3b5dd8e 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -2828,6 +2828,8 @@ protocol.version::\n * `1` - the original wire protocol with the addition of a version string\n in the initial response from the server.\n \n+* `2` - link:technical/protocol-v2.html[wire protocol version 2].\n+\n --\n \n pull.ff::\n-- \n2.19.0.rc2.392.g5ba43deb5a-goog\n\n"},{"id":"357833","messageId":"20180910213006.GH26356@aiede.svl.corp.google.com","threadId":"48550","inReplyTo":"20180910212157.134291-1-steadmon@google.com","subject":"Re: [PATCH v2] config: document value 2 for protocol.version","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-09-10T21:30:06Z","receivedAt":"2018-09-10T21:30:11Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Josh Steadmon wrote:\n\n> From: Brandon Williams \n>\n> Update the config documentation to note the value `2` as an acceptable\n> value for the protocol.version config.\n>\n> Signed-off-by: Brandon Williams \n> Signed-off-by: Josh Steadmon \n> ---\n> Documentation/config.txt | 2 ++\n> 1 file changed, 2 insertions(+)\n\nReviewed-by: Jonathan Nieder \n\nThanks.\n"},{"id":"357837","messageId":"xmqq7ejtrp1i.fsf@gitster-ct.c.googlers.com","threadId":"48550","inReplyTo":"20180910213006.GH26356@aiede.svl.corp.google.com","subject":"Re: [PATCH v2] config: document value 2 for protocol.version","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-09-10T22:00:25Z","receivedAt":"2018-09-10T22:00:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder writes:\n\n> Josh Steadmon wrote:\n>\n>> From: Brandon Williams \n>>\n>> Update the config documentation to note the value `2` as an acceptable\n>> value for the protocol.version config.\n>>\n>> Signed-off-by: Brandon Williams \n>> Signed-off-by: Josh Steadmon \n>> ---\n>> Documentation/config.txt | 2 ++\n>> 1 file changed, 2 insertions(+)\n>\n> Reviewed-by: Jonathan Nieder \n>\n> Thanks.\n\nThanks.\n"}]}