[PATCH 2/2] parse-options: remove the unused parse_opt_commits() function

Ramsay Jones· Mar 2, 2018, 02:56 UTC · lore

Commit fcfba37337 ('ref-filter: make "--contains <id>" less chatty if <id> is invalid', 2018-02-23), removed the last use of the callback function parse_opt_commits(). Remove this function declaration and definition, since it is now dead code.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 parse-options-cb.c | 16 ----------------
 parse-options.h    |  1 -
 2 files changed, 17 deletions(-)

Show changes to 2 files +0 −17

parse-options-cb.c, parse-options.h

diff --git a/parse-options-cb.c b/parse-options-cb.c
index c6679cb2c..c7320a73f 100644
--- a/parse-options-cb.c
+++ b/parse-options-cb.c
@@ -78,22 +78,6 @@ int parse_opt_verbosity_cb(const struct option *opt, const char *arg,
 	return 0;
 }
 
-int parse_opt_commits(const struct option *opt, const char *arg, int unset)
-{
-	struct object_id oid;
-	struct commit *commit;
-
-	if (!arg)
-		return -1;
-	if (get_oid(arg, &oid))
-		return error("malformed object name %s", arg);
-	commit = lookup_commit_reference(&oid);
-	if (!commit)
-		return error("no such commit %s", arg);
-	commit_list_insert(commit, opt->value);
-	return 0;
-}
-
 int parse_opt_object_name(const struct option *opt, const char *arg, int unset)
 {
 	struct object_id oid;
diff --git a/parse-options.h b/parse-options.h
index 4b4734f2e..2b8378ac1 100644
--- a/parse-options.h
+++ b/parse-options.h
@@ -224,7 +224,6 @@ extern int parse_opt_expiry_date_cb(const struct option *, const char *, int);
 extern int parse_opt_color_flag_cb(const struct option *, const char *, int);
 extern int parse_opt_verbosity_cb(const struct option *, const char *, int);
 extern int parse_opt_object_name(const struct option *, const char *, int);
-extern int parse_opt_commits(const struct option *, const char *, int);
 extern int parse_opt_tertiary(const struct option *, const char *, int);
 extern int parse_opt_string_list(const struct option *, const char *, int);
 extern int parse_opt_noop_cb(const struct option *, const char *, int);

-- 
2.16.0

Jonathan Nieder· Mar 2, 2018, 04:00 UTC · re: Ramsay Jones · lore

Re: [PATCH 2/2] parse-options: remove the unused parse_opt_commits() function

Ramsay Jones wrote:

Show 10 quoted lines

> Commit fcfba37337 ('ref-filter: make "--contains <id>" less chatty if
> <id> is invalid', 2018-02-23), removed the last use of the callback
> function parse_opt_commits(). Remove this function declaration and
> definition, since it is now dead code.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  parse-options-cb.c | 16 ----------------
>  parse-options.h    |  1 -
>  2 files changed, 17 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.

patch, 2 partsparse-options: remove the unused parse_opt_commits() function