# [PATCH 2/2] parse-options: remove the unused parse_opt_commits() function 2 messages from 2018-03-02 to 2018-03-02. Participants: Ramsay Jones, Jonathan Nieder. Thread: https://gitlist.dev/t/47958 ## Ramsay Jones, 2018-03-02 02:56 Subject: [PATCH 2/2] parse-options: remove the unused parse_opt_commits() function Message-ID: <1b5dcc90-896b-9a45-e1eb-c7ee946a2105@ramsayjones.plus.com> URL: https://gitlist.dev/e/1b5dcc90-896b-9a45-e1eb-c7ee946a2105%40ramsayjones.plus.com ``` Commit fcfba37337 ('ref-filter: make "--contains " less chatty if is invalid', 2018-02-23), removed the last use of the callback function parse_opt_commits(). Remove this function declaration and definition, since it is now dead code. Signed-off-by: Ramsay Jones --- parse-options-cb.c | 16 ---------------- parse-options.h | 1 - 2 files changed, 17 deletions(-) diff --git a/parse-options-cb.c b/parse-options-cb.c index c6679cb2c..c7320a73f 100644 --- a/parse-options-cb.c +++ b/parse-options-cb.c @@ -78,22 +78,6 @@ int parse_opt_verbosity_cb(const struct option *opt, const char *arg, return 0; } -int parse_opt_commits(const struct option *opt, const char *arg, int unset) -{ - struct object_id oid; - struct commit *commit; - - if (!arg) - return -1; - if (get_oid(arg, &oid)) - return error("malformed object name %s", arg); - commit = lookup_commit_reference(&oid); - if (!commit) - return error("no such commit %s", arg); - commit_list_insert(commit, opt->value); - return 0; -} - int parse_opt_object_name(const struct option *opt, const char *arg, int unset) { struct object_id oid; diff --git a/parse-options.h b/parse-options.h index 4b4734f2e..2b8378ac1 100644 --- a/parse-options.h +++ b/parse-options.h @@ -224,7 +224,6 @@ extern int parse_opt_expiry_date_cb(const struct option *, const char *, int); extern int parse_opt_color_flag_cb(const struct option *, const char *, int); extern int parse_opt_verbosity_cb(const struct option *, const char *, int); extern int parse_opt_object_name(const struct option *, const char *, int); -extern int parse_opt_commits(const struct option *, const char *, int); extern int parse_opt_tertiary(const struct option *, const char *, int); extern int parse_opt_string_list(const struct option *, const char *, int); extern int parse_opt_noop_cb(const struct option *, const char *, int); -- 2.16.0 ``` ## Jonathan Nieder, 2018-03-02 04:00 Subject: Re: [PATCH 2/2] parse-options: remove the unused parse_opt_commits() function Message-ID: <20180302040011.GB238112@aiede.svl.corp.google.com> URL: https://gitlist.dev/e/20180302040011.GB238112%40aiede.svl.corp.google.com In-Reply-To: <1b5dcc90-896b-9a45-e1eb-c7ee946a2105@ramsayjones.plus.com> ``` Ramsay Jones wrote: > Commit fcfba37337 ('ref-filter: make "--contains " less chatty if > is invalid', 2018-02-23), removed the last use of the callback > function parse_opt_commits(). Remove this function declaration and > definition, since it is now dead code. > > Signed-off-by: Ramsay Jones > --- > parse-options-cb.c | 16 ---------------- > parse-options.h | 1 - > 2 files changed, 17 deletions(-) Reviewed-by: Jonathan Nieder Thanks. ```