{"thread":{"id":"47958","subject":"[PATCH 2/2] parse-options: remove the unused parse_opt_commits() function","startedAt":"2018-03-02T02:56:12Z","lastAt":"2018-03-02T04:00:18Z","messageCount":2,"participants":["Ramsay Jones","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"340778","messageId":"1b5dcc90-896b-9a45-e1eb-c7ee946a2105@ramsayjones.plus.com","threadId":"47958","inReplyTo":null,"subject":"[PATCH 2/2] parse-options: remove the unused parse_opt_commits() function","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2018-03-02T02:56:05Z","receivedAt":"2018-03-02T02:56:12Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit fcfba37337 ('ref-filter: make \"--contains <id>\" less chatty if\n<id> is invalid', 2018-02-23), removed the last use of the callback\nfunction parse_opt_commits(). Remove this function declaration and\ndefinition, since it is now dead code.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n parse-options-cb.c | 16 ----------------\n parse-options.h    |  1 -\n 2 files changed, 17 deletions(-)\n\ndiff --git a/parse-options-cb.c b/parse-options-cb.c\nindex c6679cb2c..c7320a73f 100644\n--- a/parse-options-cb.c\n+++ b/parse-options-cb.c\n@@ -78,22 +78,6 @@ int parse_opt_verbosity_cb(const struct option *opt, const char *arg,\n \treturn 0;\n }\n \n-int parse_opt_commits(const struct option *opt, const char *arg, int unset)\n-{\n-\tstruct object_id oid;\n-\tstruct commit *commit;\n-\n-\tif (!arg)\n-\t\treturn -1;\n-\tif (get_oid(arg, &oid))\n-\t\treturn error(\"malformed object name %s\", arg);\n-\tcommit = lookup_commit_reference(&oid);\n-\tif (!commit)\n-\t\treturn error(\"no such commit %s\", arg);\n-\tcommit_list_insert(commit, opt->value);\n-\treturn 0;\n-}\n-\n int parse_opt_object_name(const struct option *opt, const char *arg, int unset)\n {\n \tstruct object_id oid;\ndiff --git a/parse-options.h b/parse-options.h\nindex 4b4734f2e..2b8378ac1 100644\n--- a/parse-options.h\n+++ b/parse-options.h\n@@ -224,7 +224,6 @@ extern int parse_opt_expiry_date_cb(const struct option *, const char *, int);\n extern int parse_opt_color_flag_cb(const struct option *, const char *, int);\n extern int parse_opt_verbosity_cb(const struct option *, const char *, int);\n extern int parse_opt_object_name(const struct option *, const char *, int);\n-extern int parse_opt_commits(const struct option *, const char *, int);\n extern int parse_opt_tertiary(const struct option *, const char *, int);\n extern int parse_opt_string_list(const struct option *, const char *, int);\n extern int parse_opt_noop_cb(const struct option *, const char *, int);\n-- \n2.16.0\n"},{"id":"340781","messageId":"20180302040011.GB238112@aiede.svl.corp.google.com","threadId":"47958","inReplyTo":"1b5dcc90-896b-9a45-e1eb-c7ee946a2105@ramsayjones.plus.com","subject":"Re: [PATCH 2/2] parse-options: remove the unused parse_opt_commits() function","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2018-03-02T04:00:11Z","receivedAt":"2018-03-02T04:00:18Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ramsay Jones wrote:\n\n> Commit fcfba37337 ('ref-filter: make \"--contains <id>\" less chatty if\n> <id> is invalid', 2018-02-23), removed the last use of the callback\n> function parse_opt_commits(). Remove this function declaration and\n> definition, since it is now dead code.\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>  parse-options-cb.c | 16 ----------------\n>  parse-options.h    |  1 -\n>  2 files changed, 17 deletions(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nThanks.\n"}]}