threads / patch / 47869

patchMakefile: remove *.spec from clean target

Subject: [PATCH] Makefile: remove *.spec from clean target

## tl;dr

2 messages between Feb 17, 2018 and Feb 17, 2018. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Todd Zullinger· Feb 17, 2018, 03:06 UTC · lore

Support for generating an rpm was dropped in ab214331cf ("Makefile: stop pretending to support rpmbuild", 2016-04-04). We don't generate any *.spec files so there is no need to clean them up.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
---

I noticed this minor cruft today. Since we don't generate a spec file, this is at best unneeded. At worst we could wrongly delete a users spec file if they happened to be working on it in their git clone and called make clean.

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index c56fdc14ca..d135f8baa1 100644
--- a/Makefile
+++ b/Makefile
@@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean
 	$(RM) $(TEST_PROGRAMS) $(NO_INSTALL)
 	$(RM) -r bin-wrappers $(dep_dirs)
 	$(RM) -r po/build/
-	$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
+	$(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
 	$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
 	$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz

-- 
2.16.2

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
A thing worth having is a thing worth cheating for.
    -- W. C. Fields

Junio C Hamano· Feb 17, 2018, 21:27 UTC · re: Todd Zullinger · lore

Re: [PATCH] Makefile: remove *.spec from clean target

Todd Zullinger <tmz@pobox.com> writes:

Show 11 quoted lines

> Support for generating an rpm was dropped in ab214331cf ("Makefile: stop
> pretending to support rpmbuild", 2016-04-04).  We don't generate any
> *.spec files so there is no need to clean them up.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>
> I noticed this minor cruft today.  Since we don't generate a
> spec file, this is at best unneeded.  At worst we could
> wrongly delete a users spec file if they happened to be
> working on it in their git clone and called make clean.

Makes perfect sense.  Thanks.

Show 19 quoted lines

>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c56fdc14ca..d135f8baa1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean
>  	$(RM) $(TEST_PROGRAMS) $(NO_INSTALL)
>  	$(RM) -r bin-wrappers $(dep_dirs)
>  	$(RM) -r po/build/
> -	$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
> +	$(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
>  	$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
>  	$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
>  	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
> -- 
> 2.16.2