{"thread":{"id":"47869","subject":"[PATCH] Makefile: remove *.spec from clean target","startedAt":"2018-02-17T03:06:32Z","lastAt":"2018-02-17T21:27:21Z","messageCount":2,"participants":["Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"339588","messageId":"20180217030623.GT27038@zaya.teonanacatl.net","threadId":"47869","inReplyTo":null,"subject":"[PATCH] Makefile: remove *.spec from clean target","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-02-17T03:06:24Z","receivedAt":"2018-02-17T03:06:32Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Support for generating an rpm was dropped in ab214331cf (\"Makefile: stop\npretending to support rpmbuild\", 2016-04-04).  We don't generate any\n*.spec files so there is no need to clean them up.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\n\nI noticed this minor cruft today.  Since we don't generate a\nspec file, this is at best unneeded.  At worst we could\nwrongly delete a users spec file if they happened to be\nworking on it in their git clone and called make clean.\n\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex c56fdc14ca..d135f8baa1 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean\n \t$(RM) $(TEST_PROGRAMS) $(NO_INSTALL)\n \t$(RM) -r bin-wrappers $(dep_dirs)\n \t$(RM) -r po/build/\n-\t$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*\n+\t$(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*\n \t$(RM) -r $(GIT_TARNAME) .doc-tmp-dir\n \t$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz\n \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n-- \n2.16.2\n\n-- \nTodd\n~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nA thing worth having is a thing worth cheating for.\n    -- W. C. Fields\n\n"},{"id":"339590","messageId":"xmqqvaev489b.fsf@gitster-ct.c.googlers.com","threadId":"47869","inReplyTo":"20180217030623.GT27038@zaya.teonanacatl.net","subject":"Re: [PATCH] Makefile: remove *.spec from clean target","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-02-17T21:27:12Z","receivedAt":"2018-02-17T21:27:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> Support for generating an rpm was dropped in ab214331cf (\"Makefile: stop\n> pretending to support rpmbuild\", 2016-04-04).  We don't generate any\n> *.spec files so there is no need to clean them up.\n>\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n>\n> I noticed this minor cruft today.  Since we don't generate a\n> spec file, this is at best unneeded.  At worst we could\n> wrongly delete a users spec file if they happened to be\n> working on it in their git clone and called make clean.\n\nMakes perfect sense.  Thanks.\n\n\n>\n>  Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index c56fdc14ca..d135f8baa1 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean\n>  \t$(RM) $(TEST_PROGRAMS) $(NO_INSTALL)\n>  \t$(RM) -r bin-wrappers $(dep_dirs)\n>  \t$(RM) -r po/build/\n> -\t$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*\n> +\t$(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*\n>  \t$(RM) -r $(GIT_TARNAME) .doc-tmp-dir\n>  \t$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz\n>  \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n> -- \n> 2.16.2\n"}]}