git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: remove *.spec from clean target

From
Todd Zullinger <tmz@pobox.com>
Date
Feb 17, 2018, 03:06 UTC
Message-ID
<20180217030623.GT27038@zaya.teonanacatl.net>

Support for generating an rpm was dropped in ab214331cf ("Makefile: stop pretending to support rpmbuild", 2016-04-04). We don't generate any *.spec files so there is no need to clean them up.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
---

I noticed this minor cruft today. Since we don't generate a spec file, this is at best unneeded. At worst we could wrongly delete a users spec file if they happened to be working on it in their git clone and called make clean.

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c56fdc14ca..d135f8baa1 100644
--- a/Makefile
+++ b/Makefile
@@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean
 	$(RM) $(TEST_PROGRAMS) $(NO_INSTALL)
 	$(RM) -r bin-wrappers $(dep_dirs)
 	$(RM) -r po/build/
-	$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
+	$(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
 	$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
 	$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
-- 
2.16.2

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
A thing worth having is a thing worth cheating for.
    -- W. C. Fields
Next: Junio C Hamano
Message 1 of 2 in “Makefile: remove *.spec from clean target”
  1. Makefile: remove *.spec from clean targetTodd Zullinger, Feb 17, 2018
  2. Junio C HamanoFeb 17, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.