threads / patch / 47423

patchgit-gui: Make push remote combobox full width

Subject: [PATCH] git-gui: Make push remote combobox full width

## tl;dr

3 messages between Dec 11, 2017 and Dec 18, 2017. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Peter Urbanec· Dec 11, 2017, 00:48 UTC · lore

When pushing changes, the Remote combobox for the Destination Repository does not take all available space in the layout. With long remote names, this causes the combobox to have truncated entries even though there is room to display them.

Anchor the remote_m combobox to both left and right edges of the grid cell and use the same padding as url_t for a consistent, dynamic layout.

Signed-off-by: Peter Urbanec <git.user@urbanec.net>
---
 lib/transport.tcl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to lib/transport.tcl +1 −1
diff --git a/lib/transport.tcl b/lib/transport.tcl
index a1a424a..1046dc5 100644
--- a/lib/transport.tcl
+++ b/lib/transport.tcl
@@ -173,7 +173,7 @@ proc do_push_anywhere {} {
 		} else {
 			eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
 		}
-		grid $w.dest.remote_r $w.dest.remote_m -sticky w
+		grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5}
 		if {[lsearch -sorted -exact $all_remotes origin] != -1} {
 			set push_remote origin
 		} else {

-- 
2.15.1
Peter Urbanec· Dec 17, 2017, 13:49 UTC · re: Peter Urbanec · lore

Re: [PATCH] git-gui: Make push remote combobox full width

Just wondering if I submitted this patch correctly and to the right place.
On 11/12/17 11:48, Peter Urbanec wrote:
Show 28 quoted lines
> When pushing changes, the Remote combobox for the Destination Repository
> does not take all available space in the layout. With long remote names,
> this causes the combobox to have truncated entries even though there is
> room to display them.
> 
> Anchor the remote_m combobox to both left and right edges of the grid
> cell and use the same padding as url_t for a consistent, dynamic layout.
> 
> 
> Signed-off-by: Peter Urbanec <git.user@urbanec.net>
> ---
>   lib/transport.tcl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/transport.tcl b/lib/transport.tcl
> index a1a424a..1046dc5 100644
> --- a/lib/transport.tcl
> +++ b/lib/transport.tcl
> @@ -173,7 +173,7 @@ proc do_push_anywhere {} {
>   		} else {
>   			eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
>   		}
> -		grid $w.dest.remote_r $w.dest.remote_m -sticky w
> +		grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5}
>   		if {[lsearch -sorted -exact $all_remotes origin] != -1} {
>   			set push_remote origin
>   		} else {
>
Eric Sunshine· Dec 18, 2017, 02:58 UTC · re: Peter Urbanec · lore

Re: [PATCH] git-gui: Make push remote combobox full width

On Sun, Dec 17, 2017 at 8:49 AM, Peter Urbanec <git.user@urbanec.net> wrote:
> Just wondering if I submitted this patch correctly and to the right place.

You sent it to the right place. Unfortunately, Pat hasn't been around much lately, so the git-gui project is apparently slumbering.

Junio has accepted a few patches for git-gui recently[1,2,3]; whether he's interested in doing the same for your patch is unknown.

[1]: https://github.com/patthoyts/git-gui/pull/17 [2]: https://github.com/patthoyts/git-gui/pull/16 [3]: https://github.com/patthoyts/git-gui/pull/15

← back to recent threads