# [PATCH] git-gui: Make push remote combobox full width 3 messages from 2017-12-11 to 2017-12-18. Participants: Peter Urbanec, Eric Sunshine. Thread: https://gitlist.dev/t/47423 ## Peter Urbanec, 2017-12-11 00:48 Subject: [PATCH] git-gui: Make push remote combobox full width Message-ID: <20171211004848.13048-1-git.user@urbanec.net> URL: https://gitlist.dev/e/20171211004848.13048-1-git.user%40urbanec.net ``` When pushing changes, the Remote combobox for the Destination Repository does not take all available space in the layout. With long remote names, this causes the combobox to have truncated entries even though there is room to display them. Anchor the remote_m combobox to both left and right edges of the grid cell and use the same padding as url_t for a consistent, dynamic layout. Signed-off-by: Peter Urbanec --- lib/transport.tcl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/transport.tcl b/lib/transport.tcl index a1a424a..1046dc5 100644 --- a/lib/transport.tcl +++ b/lib/transport.tcl @@ -173,7 +173,7 @@ proc do_push_anywhere {} { } else { eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes } - grid $w.dest.remote_r $w.dest.remote_m -sticky w + grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5} if {[lsearch -sorted -exact $all_remotes origin] != -1} { set push_remote origin } else { -- 2.15.1 ``` ## Peter Urbanec, 2017-12-17 13:49 Subject: Re: [PATCH] git-gui: Make push remote combobox full width Message-ID: <7aff934e-c26a-8259-17e0-436104f377cf@urbanec.net> URL: https://gitlist.dev/e/7aff934e-c26a-8259-17e0-436104f377cf%40urbanec.net In-Reply-To: <20171211004848.13048-1-git.user@urbanec.net> ``` Just wondering if I submitted this patch correctly and to the right place. On 11/12/17 11:48, Peter Urbanec wrote: > When pushing changes, the Remote combobox for the Destination Repository > does not take all available space in the layout. With long remote names, > this causes the combobox to have truncated entries even though there is > room to display them. > > Anchor the remote_m combobox to both left and right edges of the grid > cell and use the same padding as url_t for a consistent, dynamic layout. > > > Signed-off-by: Peter Urbanec > --- > lib/transport.tcl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/transport.tcl b/lib/transport.tcl > index a1a424a..1046dc5 100644 > --- a/lib/transport.tcl > +++ b/lib/transport.tcl > @@ -173,7 +173,7 @@ proc do_push_anywhere {} { > } else { > eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes > } > - grid $w.dest.remote_r $w.dest.remote_m -sticky w > + grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5} > if {[lsearch -sorted -exact $all_remotes origin] != -1} { > set push_remote origin > } else { > ``` ## Eric Sunshine, 2017-12-18 02:58 Subject: Re: [PATCH] git-gui: Make push remote combobox full width Message-ID: URL: https://gitlist.dev/e/CAPig%2BcRSPyR9dwbA7rHhYGorKQFr2Kh64PQtgQK3nxoQXvUGhw%40mail.gmail.com In-Reply-To: <7aff934e-c26a-8259-17e0-436104f377cf@urbanec.net> ``` On Sun, Dec 17, 2017 at 8:49 AM, Peter Urbanec wrote: > Just wondering if I submitted this patch correctly and to the right place. You sent it to the right place. Unfortunately, Pat hasn't been around much lately, so the git-gui project is apparently slumbering. Junio has accepted a few patches for git-gui recently[1,2,3]; whether he's interested in doing the same for your patch is unknown. [1]: https://github.com/patthoyts/git-gui/pull/17 [2]: https://github.com/patthoyts/git-gui/pull/16 [3]: https://github.com/patthoyts/git-gui/pull/15 ```