git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Make push remote combobox full width

From
PUPeter Urbanec <git.user@urbanec.net>
Date
Dec 17, 2017, 13:49 UTC
Message-ID
<7aff934e-c26a-8259-17e0-436104f377cf@urbanec.net>
In-Reply-To
<20171211004848.13048-1-git.user@urbanec.net>
Just wondering if I submitted this patch correctly and to the right place.
On 11/12/17 11:48, Peter Urbanec wrote:
Show 28 quoted lines
> When pushing changes, the Remote combobox for the Destination Repository
> does not take all available space in the layout. With long remote names,
> this causes the combobox to have truncated entries even though there is
> room to display them.
> 
> Anchor the remote_m combobox to both left and right edges of the grid
> cell and use the same padding as url_t for a consistent, dynamic layout.
> 
> 
> Signed-off-by: Peter Urbanec <git.user@urbanec.net>
> ---
>   lib/transport.tcl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/transport.tcl b/lib/transport.tcl
> index a1a424a..1046dc5 100644
> --- a/lib/transport.tcl
> +++ b/lib/transport.tcl
> @@ -173,7 +173,7 @@ proc do_push_anywhere {} {
>   		} else {
>   			eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
>   		}
> -		grid $w.dest.remote_r $w.dest.remote_m -sticky w
> +		grid $w.dest.remote_r $w.dest.remote_m -sticky we -padx {0 5}
>   		if {[lsearch -sorted -exact $all_remotes origin] != -1} {
>   			set push_remote origin
>   		} else {
> 
Previous: Peter UrbanecNext: Eric Sunshine
Message 2 of 3 in “git-gui: Make push remote combobox full width”
  1. git-gui: Make push remote combobox full widthPeter Urbanec, Dec 11, 2017
  2. Peter UrbanecDec 17, 2017
  3. Eric SunshineDec 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.