[PATCH] strbuf: Remove unused stripspace function alias

Elijah Newren· Nov 29, 2017, 01:45 UTC · lore

In commit 63af4a8446 ("strbuf: make stripspace() part of strbuf", 2015-10-16), stripspace() was moved to strbuf and renamed to strbuf_stripspace(). A "temporary" alias was added for the old name until all topic branches had time to switch over. They have had time, so remove the old alias.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 strbuf.h | 9 ---------
 1 file changed, 9 deletions(-)

Show changes to strbuf.h +0 −9

diff --git a/strbuf.h b/strbuf.h
index 0a74acb236..14c8c10d66 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -480,15 +480,6 @@ extern int strbuf_normalize_path(struct strbuf *sb);
  */
 extern void strbuf_stripspace(struct strbuf *buf, int skip_comments);
 
-/**
- * Temporary alias until all topic branches have switched to use
- * strbuf_stripspace directly.
- */
-static inline void stripspace(struct strbuf *buf, int skip_comments)
-{
-	strbuf_stripspace(buf, skip_comments);
-}
-
 static inline int strbuf_strip_suffix(struct strbuf *sb, const char *suffix)
 {
 	if (strip_suffix_mem(sb->buf, &sb->len, suffix)) {

-- 
2.15.0.408.g850bc54b15

Tobias Klauser· Nov 29, 2017, 08:47 UTC · re: Elijah Newren · lore

Re: [PATCH] strbuf: Remove unused stripspace function alias

On 2017-11-29 at 02:45:59 +0100, Elijah Newren <newren@gmail.com> wrote:

Show 7 quoted lines

> In commit 63af4a8446 ("strbuf: make stripspace() part of strbuf",
> 2015-10-16), stripspace() was moved to strbuf and renamed to
> strbuf_stripspace().  A "temporary" alias was added for the old name until
> all topic branches had time to switch over.  They have had time, so remove
> the old alias.
> 
> Signed-off-by: Elijah Newren <newren@gmail.com>

Reviewed-by: Tobias Klauser <tklauser@distanz.ch>

Thanks!

patchstrbuf: Remove unused stripspace function alias