{"thread":{"id":"47341","subject":"[PATCH] strbuf: Remove unused stripspace function alias","startedAt":"2017-11-29T01:46:45Z","lastAt":"2017-11-29T08:48:03Z","messageCount":2,"participants":["Elijah Newren","Tobias Klauser"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"333756","messageId":"20171129014559.32755-1-newren@gmail.com","threadId":"47341","inReplyTo":null,"subject":"[PATCH] strbuf: Remove unused stripspace function alias","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2017-11-29T01:45:59Z","receivedAt":"2017-11-29T01:46:45Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"In commit 63af4a8446 (\"strbuf: make stripspace() part of strbuf\",\n2015-10-16), stripspace() was moved to strbuf and renamed to\nstrbuf_stripspace().  A \"temporary\" alias was added for the old name until\nall topic branches had time to switch over.  They have had time, so remove\nthe old alias.\n\nSigned-off-by: Elijah Newren <newren@gmail.com>\n---\n strbuf.h | 9 ---------\n 1 file changed, 9 deletions(-)\n\ndiff --git a/strbuf.h b/strbuf.h\nindex 0a74acb236..14c8c10d66 100644\n--- a/strbuf.h\n+++ b/strbuf.h\n@@ -480,15 +480,6 @@ extern int strbuf_normalize_path(struct strbuf *sb);\n  */\n extern void strbuf_stripspace(struct strbuf *buf, int skip_comments);\n \n-/**\n- * Temporary alias until all topic branches have switched to use\n- * strbuf_stripspace directly.\n- */\n-static inline void stripspace(struct strbuf *buf, int skip_comments)\n-{\n-\tstrbuf_stripspace(buf, skip_comments);\n-}\n-\n static inline int strbuf_strip_suffix(struct strbuf *sb, const char *suffix)\n {\n \tif (strip_suffix_mem(sb->buf, &sb->len, suffix)) {\n-- \n2.15.0.408.g850bc54b15\n\n"},{"id":"333776","messageId":"20171129084755.GM1370@distanz.ch","threadId":"47341","inReplyTo":"20171129014559.32755-1-newren@gmail.com","subject":"Re: [PATCH] strbuf: Remove unused stripspace function alias","fromName":"Tobias Klauser","fromEmail":"tklauser@distanz.ch","sentAt":"2017-11-29T08:47:56Z","receivedAt":"2017-11-29T08:48:03Z","isPatch":true,"sender":{"key":"tklauser@distanz.ch","avatar":"https://avatars.githubusercontent.com/u/539708?v=4"},"body":"On 2017-11-29 at 02:45:59 +0100, Elijah Newren <newren@gmail.com> wrote:\n> In commit 63af4a8446 (\"strbuf: make stripspace() part of strbuf\",\n> 2015-10-16), stripspace() was moved to strbuf and renamed to\n> strbuf_stripspace().  A \"temporary\" alias was added for the old name until\n> all topic branches had time to switch over.  They have had time, so remove\n> the old alias.\n> \n> Signed-off-by: Elijah Newren <newren@gmail.com>\n\nReviewed-by: Tobias Klauser <tklauser@distanz.ch>\n\nThanks!\n"}]}