# [PATCH] strbuf: Remove unused stripspace function alias 2 messages from 2017-11-29 to 2017-11-29. Participants: Elijah Newren, Tobias Klauser. Thread: https://gitlist.dev/t/47341 ## Elijah Newren, 2017-11-29 01:45 Subject: [PATCH] strbuf: Remove unused stripspace function alias Message-ID: <20171129014559.32755-1-newren@gmail.com> URL: https://gitlist.dev/e/20171129014559.32755-1-newren%40gmail.com ``` In commit 63af4a8446 ("strbuf: make stripspace() part of strbuf", 2015-10-16), stripspace() was moved to strbuf and renamed to strbuf_stripspace(). A "temporary" alias was added for the old name until all topic branches had time to switch over. They have had time, so remove the old alias. Signed-off-by: Elijah Newren --- strbuf.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/strbuf.h b/strbuf.h index 0a74acb236..14c8c10d66 100644 --- a/strbuf.h +++ b/strbuf.h @@ -480,15 +480,6 @@ extern int strbuf_normalize_path(struct strbuf *sb); */ extern void strbuf_stripspace(struct strbuf *buf, int skip_comments); -/** - * Temporary alias until all topic branches have switched to use - * strbuf_stripspace directly. - */ -static inline void stripspace(struct strbuf *buf, int skip_comments) -{ - strbuf_stripspace(buf, skip_comments); -} - static inline int strbuf_strip_suffix(struct strbuf *sb, const char *suffix) { if (strip_suffix_mem(sb->buf, &sb->len, suffix)) { -- 2.15.0.408.g850bc54b15 ``` ## Tobias Klauser, 2017-11-29 08:47 Subject: Re: [PATCH] strbuf: Remove unused stripspace function alias Message-ID: <20171129084755.GM1370@distanz.ch> URL: https://gitlist.dev/e/20171129084755.GM1370%40distanz.ch In-Reply-To: <20171129014559.32755-1-newren@gmail.com> ``` On 2017-11-29 at 02:45:59 +0100, Elijah Newren wrote: > In commit 63af4a8446 ("strbuf: make stripspace() part of strbuf", > 2015-10-16), stripspace() was moved to strbuf and renamed to > strbuf_stripspace(). A "temporary" alias was added for the old name until > all topic branches had time to switch over. They have had time, so remove > the old alias. > > Signed-off-by: Elijah Newren Reviewed-by: Tobias Klauser Thanks! ```