threads / patch / 47302

v2, 2 partsstash-store: add failing test for same-ref

Subject: [PATCH v2 2/2] stash-store: add failing test for same-ref

## tl;dr

2 messages between Nov 22, 2017 and Nov 24, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Phil Hord· Nov 22, 2017, 21:28 UTC · lore

stash-store cannot create a new stash with the same ref as stash@{0}. No error is returned even though no new stash log is created. Add a failing test to track.

Signed-off-by: Phil Hord <phil.hord@gmail.com>
---
 t/t3903-stash.sh | 11 +++++++++++
 1 file changed, 11 insertions(+)

Show changes to t/t3903-stash.sh +11 −0

diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 279e31717..7d511afd3 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -813,6 +813,17 @@ test_expect_success 'push -m also works without space' '
 	test_cmp expect actual
 '
 
+test_expect_failure 'store same ref twice' '
+	>foo &&
+	git add foo &&
+	STASH_ID=$(git stash create) &&
+	git stash store -m "original message" $STASH_ID &&
+	git stash store -m "custom message" $STASH_ID &&
+	echo "stash@{0}: custom message" >expect &&
+	git stash list -1 >actual &&
+	test_cmp expect actual
+'
+
 test_expect_success 'store -m foo shows right message' '
 	>foo &&
 	git add foo &&

-- 
2.15.0.471.g17a719cfe.dirty

Junio C Hamano· Nov 24, 2017, 05:49 UTC · re: Phil Hord · lore

Re: [PATCH v2 2/2] stash-store: add failing test for same-ref

Phil Hord <phil.hord@gmail.com> writes:

Show 6 quoted lines

> stash-store cannot create a new stash with the same ref as stash@{0}. No
> error is returned even though no new stash log is created. Add a failing
> test to track.
>
> Signed-off-by: Phil Hord <phil.hord@gmail.com>
> ---

Sorry, I lost track. Where is v1 of this series and 1/2 of v2? IOW, where does this patch fit in in the larger picture?

Show 25 quoted lines

>  t/t3903-stash.sh | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index 279e31717..7d511afd3 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -813,6 +813,17 @@ test_expect_success 'push -m also works without space' '
>  	test_cmp expect actual
>  '
>  
> +test_expect_failure 'store same ref twice' '
> +	>foo &&
> +	git add foo &&
> +	STASH_ID=$(git stash create) &&
> +	git stash store -m "original message" $STASH_ID &&
> +	git stash store -m "custom message" $STASH_ID &&
> +	echo "stash@{0}: custom message" >expect &&
> +	git stash list -1 >actual &&
> +	test_cmp expect actual
> +'
> +
>  test_expect_success 'store -m foo shows right message' '
>  	>foo &&
>  	git add foo &&