Re: [PATCH v2 2/2] stash-store: add failing test for same-ref

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 24, 2017, 05:49 UTC
Message-ID: <xmqqzi7cns4l.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171122212802.7068-1-phil.hord@gmail.com>

Phil Hord <phil.hord@gmail.com> writes:

Show 6 quoted lines

> stash-store cannot create a new stash with the same ref as stash@{0}. No
> error is returned even though no new stash log is created. Add a failing
> test to track.
>
> Signed-off-by: Phil Hord <phil.hord@gmail.com>
> ---

Sorry, I lost track. Where is v1 of this series and 1/2 of v2? IOW, where does this patch fit in in the larger picture?

Show 25 quoted lines

>  t/t3903-stash.sh | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index 279e31717..7d511afd3 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -813,6 +813,17 @@ test_expect_success 'push -m also works without space' '
>  	test_cmp expect actual
>  '
>  
> +test_expect_failure 'store same ref twice' '
> +	>foo &&
> +	git add foo &&
> +	STASH_ID=$(git stash create) &&
> +	git stash store -m "original message" $STASH_ID &&
> +	git stash store -m "custom message" $STASH_ID &&
> +	echo "stash@{0}: custom message" >expect &&
> +	git stash list -1 >actual &&
> +	test_cmp expect actual
> +'
> +
>  test_expect_success 'store -m foo shows right message' '
>  	>foo &&
>  	git add foo &&