{"thread":{"id":"47302","subject":"[PATCH v2 2/2] stash-store: add failing test for same-ref","startedAt":"2017-11-22T21:28:25Z","lastAt":"2017-11-24T05:49:20Z","messageCount":2,"participants":["Phil Hord","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"333326","messageId":"20171122212802.7068-1-phil.hord@gmail.com","threadId":"47302","inReplyTo":null,"subject":"[PATCH v2 2/2] stash-store: add failing test for same-ref","fromName":"Phil Hord","fromEmail":"phil.hord@gmail.com","sentAt":"2017-11-22T21:28:02Z","receivedAt":"2017-11-22T21:28:25Z","isPatch":true,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"stash-store cannot create a new stash with the same ref as stash@{0}. No\nerror is returned even though no new stash log is created. Add a failing\ntest to track.\n\nSigned-off-by: Phil Hord <phil.hord@gmail.com>\n---\n t/t3903-stash.sh | 11 +++++++++++\n 1 file changed, 11 insertions(+)\n\ndiff --git a/t/t3903-stash.sh b/t/t3903-stash.sh\nindex 279e31717..7d511afd3 100755\n--- a/t/t3903-stash.sh\n+++ b/t/t3903-stash.sh\n@@ -813,6 +813,17 @@ test_expect_success 'push -m also works without space' '\n \ttest_cmp expect actual\n '\n \n+test_expect_failure 'store same ref twice' '\n+\t>foo &&\n+\tgit add foo &&\n+\tSTASH_ID=$(git stash create) &&\n+\tgit stash store -m \"original message\" $STASH_ID &&\n+\tgit stash store -m \"custom message\" $STASH_ID &&\n+\techo \"stash@{0}: custom message\" >expect &&\n+\tgit stash list -1 >actual &&\n+\ttest_cmp expect actual\n+'\n+\n test_expect_success 'store -m foo shows right message' '\n \t>foo &&\n \tgit add foo &&\n-- \n2.15.0.471.g17a719cfe.dirty\n\n"},{"id":"333411","messageId":"xmqqzi7cns4l.fsf@gitster.mtv.corp.google.com","threadId":"47302","inReplyTo":"20171122212802.7068-1-phil.hord@gmail.com","subject":"Re: [PATCH v2 2/2] stash-store: add failing test for same-ref","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-24T05:49:14Z","receivedAt":"2017-11-24T05:49:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Phil Hord <phil.hord@gmail.com> writes:\n\n> stash-store cannot create a new stash with the same ref as stash@{0}. No\n> error is returned even though no new stash log is created. Add a failing\n> test to track.\n>\n> Signed-off-by: Phil Hord <phil.hord@gmail.com>\n> ---\n\nSorry, I lost track.  Where is v1 of this series and 1/2 of v2?\nIOW, where does this patch fit in in the larger picture?\n\n>  t/t3903-stash.sh | 11 +++++++++++\n>  1 file changed, 11 insertions(+)\n>\n> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh\n> index 279e31717..7d511afd3 100755\n> --- a/t/t3903-stash.sh\n> +++ b/t/t3903-stash.sh\n> @@ -813,6 +813,17 @@ test_expect_success 'push -m also works without space' '\n>  \ttest_cmp expect actual\n>  '\n>  \n> +test_expect_failure 'store same ref twice' '\n> +\t>foo &&\n> +\tgit add foo &&\n> +\tSTASH_ID=$(git stash create) &&\n> +\tgit stash store -m \"original message\" $STASH_ID &&\n> +\tgit stash store -m \"custom message\" $STASH_ID &&\n> +\techo \"stash@{0}: custom message\" >expect &&\n> +\tgit stash list -1 >actual &&\n> +\ttest_cmp expect actual\n> +'\n> +\n>  test_expect_success 'store -m foo shows right message' '\n>  \t>foo &&\n>  \tgit add foo &&\n"}]}