threads / patch / 46922

patchcompletion: Add forgotten describe options

Subject: [PATCH 1/1] completion: Add forgotten describe options

## tl;dr

4 messages between Oct 5, 2017 and Oct 6, 2017. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Thomas Braun· Oct 5, 2017, 21:23 UTC · lore

Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to contrib/completion/git-completion.bash +1 −1

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d934417475..0e16f017a4 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1385,7 +1385,7 @@ _git_describe ()
 		__gitcomp "
 			--all --tags --contains --abbrev= --candidates=
 			--exact-match --debug --long --match --always --first-parent
-			--exclude
+			--exclude --dirty --broken
 			"
 		return
 	esac

-- 
2.14.2.746.g8fb8a945bc.dirty

Stefan Beller· Oct 5, 2017, 22:17 UTC · re: Thomas Braun · lore

Re: [PATCH 1/1] completion: Add forgotten describe options

On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun <thomas.braun@virtuell-zuhause.de> wrote:

> completion: Add forgotten describe options

When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21) Which do you add? (dirty and broken)

I had these questions when reading the subject (which is the equivalent of reading the output of `git log --oneline` in the future) I think a better wording might be

    completion: add --broken and --dirty to describe

    When the flags for broken and dirty were implemented in
    b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
    and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
    the completion was not updated, although these flags are useful
    completions. Add them.

> Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
> ---

The patch looks correct.

Thanks, Stefan

Show 19 quoted lines

>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d934417475..0e16f017a4 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1385,7 +1385,7 @@ _git_describe ()
>                 __gitcomp "
>                         --all --tags --contains --abbrev= --candidates=
>                         --exact-match --debug --long --match --always --first-parent
> -                       --exclude
> +                       --exclude --dirty --broken
>                         "
>                 return
>         esac
> --
> 2.14.2.746.g8fb8a945bc.dirty
>

Thomas Braun· Oct 6, 2017, 17:53 UTC · re: Stefan Beller · lore

Re: [PATCH 1/1] completion: Add forgotten describe options

> Stefan Beller <sbeller@google.com> hat am 6. Oktober 2017 um 00:17 geschrieben:
> On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun
> <thomas.braun@virtuell-zuhause.de> wrote:

Hi Stefan,

Show 17 quoted lines

> > completion: Add forgotten describe options
> 
> When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5
> (builtin/describe: introduce --broken flag, 2017-03-21)
> Which do you add? (dirty and broken)
> 
> I had these questions when reading the subject (which is the
> equivalent of reading the output of `git log --oneline` in the future)
> I think a better wording might be
> 
>     completion: add --broken and --dirty to describe
> 
>     When the flags for broken and dirty were implemented in
>     b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
>     and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
>     the completion was not updated, although these flags are useful
>     completions. Add them.

Thanks for the review. Your commit message is (obviously) much better than mine. Reroll follows.

> > ---
> 
> The patch looks correct.
>

Thanks, Thomas

Thomas Braun· Oct 6, 2017, 18:02 UTC · re: Thomas Braun · lore

[PATCH v2 1/1] completion: add --broken and --dirty to describe

When the flags for broken and dirty were implemented in b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21) and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21) the completion was not updated, although these flags are useful completions. Add them.

Signed-off-by: Thomas Braun <thomas.braun@virtuell-zuhause.de>
Helped-by: Stefan Beller <sbeller@google.com>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to contrib/completion/git-completion.bash +1 −1

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d934417475..0e16f017a4 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1385,7 +1385,7 @@ _git_describe ()
 		__gitcomp "
 			--all --tags --contains --abbrev= --candidates=
 			--exact-match --debug --long --match --always --first-parent
-			--exclude
+			--exclude --dirty --broken
 			"
 		return
 	esac

-- 
2.14.2.746.g8fb8a945bc.dirty