# [PATCH 1/1] completion: Add forgotten describe options 4 messages from 2017-10-05 to 2017-10-06. Participants: Thomas Braun, Stefan Beller. Thread: https://gitlist.dev/t/46922 ## Thomas Braun, 2017-10-05 21:23 Subject: [PATCH 1/1] completion: Add forgotten describe options Message-ID: <20171005212344.22887-1-thomas.braun@virtuell-zuhause.de> URL: https://gitlist.dev/e/20171005212344.22887-1-thomas.braun%40virtuell-zuhause.de ``` Signed-off-by: Thomas Braun --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index d934417475..0e16f017a4 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1385,7 +1385,7 @@ _git_describe () __gitcomp " --all --tags --contains --abbrev= --candidates= --exact-match --debug --long --match --always --first-parent - --exclude + --exclude --dirty --broken " return esac -- 2.14.2.746.g8fb8a945bc.dirty ``` ## Stefan Beller, 2017-10-05 22:17 Subject: Re: [PATCH 1/1] completion: Add forgotten describe options Message-ID: URL: https://gitlist.dev/e/CAGZ79kbp%3DewvdR8gXptwDjDdtM3TdC8qp1qR8XhETa7_CKgqRQ%40mail.gmail.com In-Reply-To: <20171005212344.22887-1-thomas.braun@virtuell-zuhause.de> ``` On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun wrote: > completion: Add forgotten describe options When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21) Which do you add? (dirty and broken) I had these questions when reading the subject (which is the equivalent of reading the output of `git log --oneline` in the future) I think a better wording might be completion: add --broken and --dirty to describe When the flags for broken and dirty were implemented in b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21) and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21) the completion was not updated, although these flags are useful completions. Add them. > Signed-off-by: Thomas Braun > --- The patch looks correct. Thanks, Stefan > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index d934417475..0e16f017a4 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1385,7 +1385,7 @@ _git_describe () > __gitcomp " > --all --tags --contains --abbrev= --candidates= > --exact-match --debug --long --match --always --first-parent > - --exclude > + --exclude --dirty --broken > " > return > esac > -- > 2.14.2.746.g8fb8a945bc.dirty > ``` ## Thomas Braun, 2017-10-06 17:53 Subject: Re: [PATCH 1/1] completion: Add forgotten describe options Message-ID: <1641255580.85206.1507312421166@ox.hosteurope.de> URL: https://gitlist.dev/e/1641255580.85206.1507312421166%40ox.hosteurope.de In-Reply-To: ``` > Stefan Beller hat am 6. Oktober 2017 um 00:17 geschrieben: > On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun > wrote: Hi Stefan, > > completion: Add forgotten describe options > > When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5 > (builtin/describe: introduce --broken flag, 2017-03-21) > Which do you add? (dirty and broken) > > I had these questions when reading the subject (which is the > equivalent of reading the output of `git log --oneline` in the future) > I think a better wording might be > > completion: add --broken and --dirty to describe > > When the flags for broken and dirty were implemented in > b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21) > and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21) > the completion was not updated, although these flags are useful > completions. Add them. Thanks for the review. Your commit message is (obviously) much better than mine. Reroll follows. > > --- > > The patch looks correct. > Thanks, Thomas ``` ## Thomas Braun, 2017-10-06 18:02 Subject: [PATCH v2 1/1] completion: add --broken and --dirty to describe Message-ID: <20171006180247.26718-1-thomas.braun@virtuell-zuhause.de> URL: https://gitlist.dev/e/20171006180247.26718-1-thomas.braun%40virtuell-zuhause.de In-Reply-To: <20171005212344.22887-1-thomas.braun@virtuell-zuhause.de> ``` When the flags for broken and dirty were implemented in b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21) and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21) the completion was not updated, although these flags are useful completions. Add them. Signed-off-by: Thomas Braun Helped-by: Stefan Beller --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index d934417475..0e16f017a4 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1385,7 +1385,7 @@ _git_describe () __gitcomp " --all --tags --contains --abbrev= --candidates= --exact-match --debug --long --match --always --first-parent - --exclude + --exclude --dirty --broken " return esac -- 2.14.2.746.g8fb8a945bc.dirty ```