{"thread":{"id":"46922","subject":"[PATCH 1/1] completion: Add forgotten describe options","startedAt":"2017-10-05T22:06:01Z","lastAt":"2017-10-06T18:03:13Z","messageCount":4,"participants":["Thomas Braun","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"329820","messageId":"20171005212344.22887-1-thomas.braun@virtuell-zuhause.de","threadId":"46922","inReplyTo":null,"subject":"[PATCH 1/1] completion: Add forgotten describe options","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2017-10-05T21:23:44Z","receivedAt":"2017-10-05T22:06:01Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"Signed-off-by: Thomas Braun \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex d934417475..0e16f017a4 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1385,7 +1385,7 @@ _git_describe ()\n \t\t__gitcomp \"\n \t\t\t--all --tags --contains --abbrev= --candidates=\n \t\t\t--exact-match --debug --long --match --always --first-parent\n-\t\t\t--exclude\n+\t\t\t--exclude --dirty --broken\n \t\t\t\"\n \t\treturn\n \tesac\n-- \n2.14.2.746.g8fb8a945bc.dirty\n\n"},{"id":"329822","messageId":"CAGZ79kbp=ewvdR8gXptwDjDdtM3TdC8qp1qR8XhETa7_CKgqRQ@mail.gmail.com","threadId":"46922","inReplyTo":"20171005212344.22887-1-thomas.braun@virtuell-zuhause.de","subject":"Re: [PATCH 1/1] completion: Add forgotten describe options","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-10-05T22:17:07Z","receivedAt":"2017-10-05T22:17:13Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun\n wrote:\n\n> completion: Add forgotten describe options\n\nWhen/Why was it forgotten? git-blame thinks it was me in b0176ce6b5\n(builtin/describe: introduce --broken flag, 2017-03-21)\nWhich do you add? (dirty and broken)\n\nI had these questions when reading the subject (which is the\nequivalent of reading the output of `git log --oneline` in the future)\nI think a better wording might be\n\n completion: add --broken and --dirty to describe\n\n When the flags for broken and dirty were implemented in\n b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)\n and 9f67d2e827 (Teach \"git describe\" --dirty option, 2009-10-21)\n the completion was not updated, although these flags are useful\n completions. Add them.\n\n> Signed-off-by: Thomas Braun \n> ---\n\nThe patch looks correct.\n\nThanks,\nStefan\n\n> contrib/completion/git-completion.bash | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index d934417475..0e16f017a4 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1385,7 +1385,7 @@ _git_describe ()\n> __gitcomp \"\n> --all --tags --contains --abbrev= --candidates=\n> --exact-match --debug --long --match --always --first-parent\n> - --exclude\n> + --exclude --dirty --broken\n> \"\n> return\n> esac\n> --\n> 2.14.2.746.g8fb8a945bc.dirty\n>\n"},{"id":"329908","messageId":"1641255580.85206.1507312421166@ox.hosteurope.de","threadId":"46922","inReplyTo":"CAGZ79kbp=ewvdR8gXptwDjDdtM3TdC8qp1qR8XhETa7_CKgqRQ@mail.gmail.com","subject":"Re: [PATCH 1/1] completion: Add forgotten describe options","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2017-10-06T17:53:41Z","receivedAt":"2017-10-06T17:53:48Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"> Stefan Beller hat am 6. Oktober 2017 um 00:17 geschrieben:\n> On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun\n> wrote:\n\nHi Stefan,\n\n> > completion: Add forgotten describe options\n> \n> When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5\n> (builtin/describe: introduce --broken flag, 2017-03-21)\n> Which do you add? (dirty and broken)\n> \n> I had these questions when reading the subject (which is the\n> equivalent of reading the output of `git log --oneline` in the future)\n> I think a better wording might be\n> \n> completion: add --broken and --dirty to describe\n> \n> When the flags for broken and dirty were implemented in\n> b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)\n> and 9f67d2e827 (Teach \"git describe\" --dirty option, 2009-10-21)\n> the completion was not updated, although these flags are useful\n> completions. Add them.\n\nThanks for the review. Your commit message is (obviously) much better than mine. Reroll follows.\n\n> > ---\n> \n> The patch looks correct.\n> \n\nThanks,\nThomas\n"},{"id":"329910","messageId":"20171006180247.26718-1-thomas.braun@virtuell-zuhause.de","threadId":"46922","inReplyTo":"20171005212344.22887-1-thomas.braun@virtuell-zuhause.de","subject":"[PATCH v2 1/1] completion: add --broken and --dirty to describe","fromName":"Thomas Braun","fromEmail":"thomas.braun@virtuell-zuhause.de","sentAt":"2017-10-06T18:02:47Z","receivedAt":"2017-10-06T18:03:13Z","isPatch":true,"sender":{"key":"thomas.braun@virtuell-zuhause.de","avatar":"https://avatars.githubusercontent.com/u/1185677?v=4"},"body":"When the flags for broken and dirty were implemented in\nb0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)\nand 9f67d2e827 (Teach \"git describe\" --dirty option, 2009-10-21)\nthe completion was not updated, although these flags are useful\ncompletions. Add them.\n\nSigned-off-by: Thomas Braun \nHelped-by: Stefan Beller \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex d934417475..0e16f017a4 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1385,7 +1385,7 @@ _git_describe ()\n \t\t__gitcomp \"\n \t\t\t--all --tags --contains --abbrev= --candidates=\n \t\t\t--exact-match --debug --long --match --always --first-parent\n-\t\t\t--exclude\n+\t\t\t--exclude --dirty --broken\n \t\t\t\"\n \t\treturn\n \tesac\n-- \n2.14.2.746.g8fb8a945bc.dirty\n\n"}]}