threads / bug / 46895

[bug] git version 2.4.12 color.ui = always breaks git add -p

Subject: [bug] git version 2.4.12 color.ui = always breaks git add -p

## tl;dr

3 messages between Oct 3, 2017 and Oct 3, 2017.

replies: 2people: 3as markdown or json

Christian Rebischke· Oct 3, 2017, 21:33 UTC · lore

Hello everybody, I played around with my gitconfig and I think I found a bug while doing so. I set the following lines in my gitconfig:

[color]
    ui = always

When I try to use `git add -p <filename>` I don't see the 'Stage this hunk'-dialog anymore. First I thought it's some other configuration but now I can definitly say that this configuration breaks `git add -p` interactive mode.

best regards

chris

Jonathan Nieder· Oct 3, 2017, 21:47 UTC · re: Christian Rebischke · lore

Re: [bug] git version 2.4.12 color.ui = always breaks git add -p

Hi Christian,

Christian Rebischke wrote:

Show 10 quoted lines

> I played around with my gitconfig and I think I found a bug while doing
> so. I set the following lines in my gitconfig:
>
> [color]
>     ui = always
>
> When I try to use `git add -p <filename>` I don't see the 'Stage
> this hunk'-dialog anymore. First I thought it's some other configuration
> but now I can definitly say that this configuration breaks `git add -p`
> interactive mode.

Do the patches at https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/ help?

Thanks and hope that helps, Jonathan

Jeff King· Oct 3, 2017, 23:53 UTC · re: Jonathan Nieder · lore

Re: [bug] git version 2.4.12 color.ui = always breaks git add -p

On Tue, Oct 03, 2017 at 02:47:48PM -0700, Jonathan Nieder wrote:

Show 18 quoted lines

> Hi Christian,
> 
> Christian Rebischke wrote:
> 
> > I played around with my gitconfig and I think I found a bug while doing
> > so. I set the following lines in my gitconfig:
> >
> > [color]
> >     ui = always
> >
> > When I try to use `git add -p <filename>` I don't see the 'Stage
> > this hunk'-dialog anymore. First I thought it's some other configuration
> > but now I can definitly say that this configuration breaks `git add -p`
> > interactive mode.
> 
> Do the patches at
> https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
> help?

If it makes it any easier to test, they are also available as a fetch from:

  https://github.com/peff/git jk/color-no-always

-Peff