Re: [bug] git version 2.4.12 color.ui = always breaks git add -p

From: Jeff King <peff@peff.net>
Date: Oct 3, 2017, 23:53 UTC
Message-ID: <20171003235309.tysfbxqmb7zbiaic@sigill.intra.peff.net>
In-Reply-To: <20171003214748.GA19555@aiede.mtv.corp.google.com>

On Tue, Oct 03, 2017 at 02:47:48PM -0700, Jonathan Nieder wrote:

Show 18 quoted lines

> Hi Christian,
> 
> Christian Rebischke wrote:
> 
> > I played around with my gitconfig and I think I found a bug while doing
> > so. I set the following lines in my gitconfig:
> >
> > [color]
> >     ui = always
> >
> > When I try to use `git add -p <filename>` I don't see the 'Stage
> > this hunk'-dialog anymore. First I thought it's some other configuration
> > but now I can definitly say that this configuration breaks `git add -p`
> > interactive mode.
> 
> Do the patches at
> https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
> help?

If it makes it any easier to test, they are also available as a fetch from:

  https://github.com/peff/git jk/color-no-always

-Peff