# [bug] git version 2.4.12 color.ui = always breaks git add -p

3 messages from 2017-10-03 to 2017-10-03. Participants: Christian Rebischke, Jonathan Nieder, Jeff King.
Thread: https://gitlist.dev/t/46895

## Christian Rebischke, 2017-10-03 21:33

Subject: [bug] git version 2.4.12 color.ui = always breaks git add -p
Message-ID: <20171003213353.GA9195@motoko>
URL: https://gitlist.dev/e/20171003213353.GA9195%40motoko

```
Hello everybody,
I played around with my gitconfig and I think I found a bug while doing
so. I set the following lines in my gitconfig:

[color]
    ui = always

When I try to use `git add -p <filename>` I don't see the 'Stage
this hunk'-dialog anymore. First I thought it's some other configuration
but now I can definitly say that this configuration breaks `git add -p`
interactive mode.

best regards

chris

```

## Jonathan Nieder, 2017-10-03 21:47

Subject: Re: [bug] git version 2.4.12 color.ui = always breaks git add -p
Message-ID: <20171003214748.GA19555@aiede.mtv.corp.google.com>
URL: https://gitlist.dev/e/20171003214748.GA19555%40aiede.mtv.corp.google.com
In-Reply-To: <20171003213353.GA9195@motoko>

```
Hi Christian,

Christian Rebischke wrote:

> I played around with my gitconfig and I think I found a bug while doing
> so. I set the following lines in my gitconfig:
>
> [color]
>     ui = always
>
> When I try to use `git add -p <filename>` I don't see the 'Stage
> this hunk'-dialog anymore. First I thought it's some other configuration
> but now I can definitly say that this configuration breaks `git add -p`
> interactive mode.

Do the patches at
https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
help?

Thanks and hope that helps,
Jonathan

```

## Jeff King, 2017-10-03 23:53

Subject: Re: [bug] git version 2.4.12 color.ui = always breaks git add -p
Message-ID: <20171003235309.tysfbxqmb7zbiaic@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20171003235309.tysfbxqmb7zbiaic%40sigill.intra.peff.net
In-Reply-To: <20171003214748.GA19555@aiede.mtv.corp.google.com>

```
On Tue, Oct 03, 2017 at 02:47:48PM -0700, Jonathan Nieder wrote:

> Hi Christian,
> 
> Christian Rebischke wrote:
> 
> > I played around with my gitconfig and I think I found a bug while doing
> > so. I set the following lines in my gitconfig:
> >
> > [color]
> >     ui = always
> >
> > When I try to use `git add -p <filename>` I don't see the 'Stage
> > this hunk'-dialog anymore. First I thought it's some other configuration
> > but now I can definitly say that this configuration breaks `git add -p`
> > interactive mode.
> 
> Do the patches at
> https://public-inbox.org/git/20171003133713.ccxv6clrmuuhhc3u@sigill.intra.peff.net/
> help?

If it makes it any easier to test, they are also available as a fetch
from:

  https://github.com/peff/git jk/color-no-always

-Peff

```