threads / patch / 46609

patchsubmodule.sh: remove unused variable

Subject: [PATCH] submodule.sh: remove unused variable

## tl;dr

2 messages between Aug 16, 2017 and Aug 16, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Stefan Beller· Aug 16, 2017, 22:50 UTC · lore

This could have been part of 48308681b0 (git submodule update: have a dedicated helper for cloning, 2016-02-29).

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 git-submodule.sh | 1 -
 1 file changed, 1 deletion(-)

Show changes to git-submodule.sh +0 −1

diff --git a/git-submodule.sh b/git-submodule.sh
index e131760eec..9dcec7b356 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -611,7 +611,6 @@ cmd_update()
 		die_if_unmatched "$mode" "$sha1"
 
 		name=$(git submodule--helper name "$sm_path") || exit
-		url=$(git config submodule."$name".url)
 		if ! test -z "$update"
 		then
 			update_module=$update

-- 
2.14.0.rc0.3.g6c2e499285

Jonathan Nieder· Aug 16, 2017, 22:59 UTC · re: Stefan Beller · lore

Re: [PATCH] submodule.sh: remove unused variable

Stefan Beller wrote:

Show 7 quoted lines

> This could have been part of 48308681b0 (git submodule update: have a
> dedicated helper for cloning, 2016-02-29).
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  git-submodule.sh | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for cleaning up.

Show 15 quoted lines

> diff --git a/git-submodule.sh b/git-submodule.sh
> index e131760eec..9dcec7b356 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -611,7 +611,6 @@ cmd_update()
>  		die_if_unmatched "$mode" "$sha1"
>  
>  		name=$(git submodule--helper name "$sm_path") || exit
> -		url=$(git config submodule."$name".url)
>  		if ! test -z "$update"
>  		then
>  			update_module=$update
> -- 
> 2.14.0.rc0.3.g6c2e499285
>