{"thread":{"id":"46609","subject":"[PATCH] submodule.sh: remove unused variable","startedAt":"2017-08-16T22:50:52Z","lastAt":"2017-08-16T22:59:28Z","messageCount":2,"participants":["Stefan Beller","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"326566","messageId":"20170816225042.32765-1-sbeller@google.com","threadId":"46609","inReplyTo":null,"subject":"[PATCH] submodule.sh: remove unused variable","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-08-16T22:50:42Z","receivedAt":"2017-08-16T22:50:52Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"This could have been part of 48308681b0 (git submodule update: have a\ndedicated helper for cloning, 2016-02-29).\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n git-submodule.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex e131760eec..9dcec7b356 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -611,7 +611,6 @@ cmd_update()\n \t\tdie_if_unmatched \"$mode\" \"$sha1\"\n \n \t\tname=$(git submodule--helper name \"$sm_path\") || exit\n-\t\turl=$(git config submodule.\"$name\".url)\n \t\tif ! test -z \"$update\"\n \t\tthen\n \t\t\tupdate_module=$update\n-- \n2.14.0.rc0.3.g6c2e499285\n\n"},{"id":"326569","messageId":"20170816225920.GJ13924@aiede.mtv.corp.google.com","threadId":"46609","inReplyTo":"20170816225042.32765-1-sbeller@google.com","subject":"Re: [PATCH] submodule.sh: remove unused variable","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-08-16T22:59:20Z","receivedAt":"2017-08-16T22:59:28Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Stefan Beller wrote:\n\n> This could have been part of 48308681b0 (git submodule update: have a\n> dedicated helper for cloning, 2016-02-29).\n>\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n>  git-submodule.sh | 1 -\n>  1 file changed, 1 deletion(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks for cleaning up.\n\n> diff --git a/git-submodule.sh b/git-submodule.sh\n> index e131760eec..9dcec7b356 100755\n> --- a/git-submodule.sh\n> +++ b/git-submodule.sh\n> @@ -611,7 +611,6 @@ cmd_update()\n>  \t\tdie_if_unmatched \"$mode\" \"$sha1\"\n>  \n>  \t\tname=$(git submodule--helper name \"$sm_path\") || exit\n> -\t\turl=$(git config submodule.\"$name\".url)\n>  \t\tif ! test -z \"$update\"\n>  \t\tthen\n>  \t\t\tupdate_module=$update\n> -- \n> 2.14.0.rc0.3.g6c2e499285\n> \n"}]}