# [PATCH] submodule.sh: remove unused variable 2 messages from 2017-08-16 to 2017-08-16. Participants: Stefan Beller, Jonathan Nieder. Thread: https://gitlist.dev/t/46609 ## Stefan Beller, 2017-08-16 22:50 Subject: [PATCH] submodule.sh: remove unused variable Message-ID: <20170816225042.32765-1-sbeller@google.com> URL: https://gitlist.dev/e/20170816225042.32765-1-sbeller%40google.com ``` This could have been part of 48308681b0 (git submodule update: have a dedicated helper for cloning, 2016-02-29). Signed-off-by: Stefan Beller --- git-submodule.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/git-submodule.sh b/git-submodule.sh index e131760eec..9dcec7b356 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -611,7 +611,6 @@ cmd_update() die_if_unmatched "$mode" "$sha1" name=$(git submodule--helper name "$sm_path") || exit - url=$(git config submodule."$name".url) if ! test -z "$update" then update_module=$update -- 2.14.0.rc0.3.g6c2e499285 ``` ## Jonathan Nieder, 2017-08-16 22:59 Subject: Re: [PATCH] submodule.sh: remove unused variable Message-ID: <20170816225920.GJ13924@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20170816225920.GJ13924%40aiede.mtv.corp.google.com In-Reply-To: <20170816225042.32765-1-sbeller@google.com> ``` Stefan Beller wrote: > This could have been part of 48308681b0 (git submodule update: have a > dedicated helper for cloning, 2016-02-29). > > Signed-off-by: Stefan Beller > --- > git-submodule.sh | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Jonathan Nieder Thanks for cleaning up. > diff --git a/git-submodule.sh b/git-submodule.sh > index e131760eec..9dcec7b356 100755 > --- a/git-submodule.sh > +++ b/git-submodule.sh > @@ -611,7 +611,6 @@ cmd_update() > die_if_unmatched "$mode" "$sha1" > > name=$(git submodule--helper name "$sm_path") || exit > - url=$(git config submodule."$name".url) > if ! test -z "$update" > then > update_module=$update > -- > 2.14.0.rc0.3.g6c2e499285 > ```