threads / patch / 46314

patchcomment: fix a typo in the comment

Subject: [PATCH] comment: fix a typo in the comment

## tl;dr

7 messages between Jul 5, 2017 and Jul 7, 2017. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Kaartic Sivaraam· Jul 5, 2017, 17:03 UTC · lore
---
 Though very trivial, I wanted to correct this as I didn't
 want to ignore it after seeing it.
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/commit.c +1 −1
diff --git a/builtin/commit.c b/builtin/commit.c
index 8d1cac0..aff6bf7 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
 	int i, eol;
 	const char *nl;
 
-	/* Check if the rest is just whitespace and Signed-of-by's. */
+	/* Check if the rest is just whitespace and Signed-off-by's. */
 	for (i = start; i < sb->len; i++) {
 		nl = memchr(sb->buf + i, '\n', sb->len - i);
 		if (nl)

-- 
2.7.4
Junio C Hamano· Jul 5, 2017, 18:18 UTC · re: Kaartic Sivaraam · lore

Re: [PATCH] comment: fix a typo in the comment

Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> ---
>  Though very trivial, I wanted to correct this as I didn't
>  want to ignore it after seeing it.
Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))
Show 17 quoted lines
>
>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 8d1cac0..aff6bf7 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
>  	int i, eol;
>  	const char *nl;
>  
> -	/* Check if the rest is just whitespace and Signed-of-by's. */
> +	/* Check if the rest is just whitespace and Signed-off-by's. */
>  	for (i = start; i < sb->len; i++) {
>  		nl = memchr(sb->buf + i, '\n', sb->len - i);
>  		if (nl)
Kaartic Sivaraam· Jul 6, 2017, 03:17 UTC · re: Junio C Hamano · lore

Re: [PATCH] comment: fix a typo in the comment

On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote:
Show 8 quoted lines
> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> 
> > ---
> >  Though very trivial, I wanted to correct this as I didn't
> >  want to ignore it after seeing it.
> 
> Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))
>

I should also thank you for your sharp eyes! BTW, this won't repeat again as I have made 'git' worry about adding the signed-off-by to the commits I do on my local version of git.git :)

-- 
Kaartic
SZEDER Gábor· Jul 6, 2017, 14:47 UTC · re: Kaartic Sivaraam · lore

Re: [PATCH] comment: fix a typo in the comment

Show 10 quoted lines
> On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote:
> > Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> > 
> > > ---
> > > �Though very trivial, I wanted to correct this as I didn't
> > > �want to ignore it after seeing it.
> > 
> > Thanks for sharp eyes.��Sign-off?��(or Sign-of? ;-))
> > 
> I should also thank you for your sharp eyes!

Speaking of sharp eyes... That Subject: line really needs a s/comment:/commit:/, doesn't it? :)

Junio C Hamano· Jul 6, 2017, 16:04 UTC · re: SZEDER Gábor · lore

Re: [PATCH] comment: fix a typo in the comment

SZEDER Gábor <szeder.dev@gmail.com> writes:
> Speaking of sharp eyes...  That Subject: line really needs a
> s/comment:/commit:/, doesn't it? :)
Surely it does.
Kaartic Sivaraam· Jul 7, 2017, 16:02 UTC · re: Junio C Hamano · lore

[PATCH] commit: fix a typo in the comment

Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/commit.c +1 −1
diff --git a/builtin/commit.c b/builtin/commit.c
index 8d1cac062..aff6bf7aa 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
 	int i, eol;
 	const char *nl;
 
-	/* Check if the rest is just whitespace and Signed-of-by's. */
+	/* Check if the rest is just whitespace and Signed-off-by's. */
 	for (i = start; i < sb->len; i++) {
 		nl = memchr(sb->buf + i, '\n', sb->len - i);
 		if (nl)

-- 
2.13.2.879.g2ab69f31a.dirty
Kaartic Sivaraam· Jul 6, 2017, 03:19 UTC · re: Junio C Hamano · lore
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
---
 builtin/commit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/commit.c +1 −1
diff --git a/builtin/commit.c b/builtin/commit.c
index 8d1cac062..aff6bf7aa 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
 	int i, eol;
 	const char *nl;
 
-	/* Check if the rest is just whitespace and Signed-of-by's. */
+	/* Check if the rest is just whitespace and Signed-off-by's. */
 	for (i = start; i < sb->len; i++) {
 		nl = memchr(sb->buf + i, '\n', sb->len - i);
 		if (nl)

-- 
2.11.0

← back to recent threads