{"thread":{"id":"46314","subject":"[PATCH] comment: fix a typo in the comment","startedAt":"2017-07-05T17:03:53Z","lastAt":"2017-07-07T16:02:59Z","messageCount":7,"participants":["Kaartic Sivaraam","Junio C Hamano","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"323845","messageId":"20170705170324.21026-1-kaarticsivaraam91196@gmail.com","threadId":"46314","inReplyTo":null,"subject":"[PATCH] comment: fix a typo in the comment","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-05T17:03:24Z","receivedAt":"2017-07-05T17:03:53Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"---\n Though very trivial, I wanted to correct this as I didn't\n want to ignore it after seeing it.\n\n builtin/commit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 8d1cac0..aff6bf7 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)\n \tint i, eol;\n \tconst char *nl;\n \n-\t/* Check if the rest is just whitespace and Signed-of-by's. */\n+\t/* Check if the rest is just whitespace and Signed-off-by's. */\n \tfor (i = start; i < sb->len; i++) {\n \t\tnl = memchr(sb->buf + i, '\\n', sb->len - i);\n \t\tif (nl)\n-- \n2.7.4\n\n"},{"id":"323857","messageId":"xmqq8tk2iw87.fsf@gitster.mtv.corp.google.com","threadId":"46314","inReplyTo":"20170705170324.21026-1-kaarticsivaraam91196@gmail.com","subject":"Re: [PATCH] comment: fix a typo in the comment","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-05T18:18:00Z","receivedAt":"2017-07-05T18:18:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:\n\n> ---\n>  Though very trivial, I wanted to correct this as I didn't\n>  want to ignore it after seeing it.\n\nThanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))\n\n>\n>  builtin/commit.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/commit.c b/builtin/commit.c\n> index 8d1cac0..aff6bf7 100644\n> --- a/builtin/commit.c\n> +++ b/builtin/commit.c\n> @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)\n>  \tint i, eol;\n>  \tconst char *nl;\n>  \n> -\t/* Check if the rest is just whitespace and Signed-of-by's. */\n> +\t/* Check if the rest is just whitespace and Signed-off-by's. */\n>  \tfor (i = start; i < sb->len; i++) {\n>  \t\tnl = memchr(sb->buf + i, '\\n', sb->len - i);\n>  \t\tif (nl)\n"},{"id":"323881","messageId":"1499311044.1776.1.camel@gmail.com","threadId":"46314","inReplyTo":"xmqq8tk2iw87.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] comment: fix a typo in the comment","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-06T03:17:24Z","receivedAt":"2017-07-06T03:17:25Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote:\n> Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:\n> \n> > ---\n> >  Though very trivial, I wanted to correct this as I didn't\n> >  want to ignore it after seeing it.\n> \n> Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))\n> \nI should also thank you for your sharp eyes! BTW, this won't repeat\nagain as I have made 'git' worry about adding the signed-off-by to the\ncommits I do on my local version of git.git :)\n\n-- \nKaartic\n"},{"id":"323882","messageId":"20170706031957.5782-1-kaarticsivaraam91196@gmail.com","threadId":"46314","inReplyTo":"xmqq8tk2iw87.fsf@gitster.mtv.corp.google.com","subject":"[PATCH] comment: fix a typo in the comment","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-06T03:19:57Z","receivedAt":"2017-07-06T03:20:22Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>\n---\n builtin/commit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 8d1cac062..aff6bf7aa 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)\n \tint i, eol;\n \tconst char *nl;\n \n-\t/* Check if the rest is just whitespace and Signed-of-by's. */\n+\t/* Check if the rest is just whitespace and Signed-off-by's. */\n \tfor (i = start; i < sb->len; i++) {\n \t\tnl = memchr(sb->buf + i, '\\n', sb->len - i);\n \t\tif (nl)\n-- \n2.11.0\n\n"},{"id":"323895","messageId":"20170706144711.31002-1-szeder.dev@gmail.com","threadId":"46314","inReplyTo":"1499311044.1776.1.camel@gmail.com","subject":"Re: [PATCH] comment: fix a typo in the comment","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2017-07-06T14:47:11Z","receivedAt":"2017-07-06T14:47:47Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"> On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote:\n> > Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:\n> > \n> > > ---\n> > > �Though very trivial, I wanted to correct this as I didn't\n> > > �want to ignore it after seeing it.\n> > \n> > Thanks for sharp eyes.��Sign-off?��(or Sign-of? ;-))\n> > \n> I should also thank you for your sharp eyes!\n\nSpeaking of sharp eyes...  That Subject: line really needs a\ns/comment:/commit:/, doesn't it? :)\n\n"},{"id":"323898","messageId":"xmqqtw2pft5p.fsf@gitster.mtv.corp.google.com","threadId":"46314","inReplyTo":"20170706144711.31002-1-szeder.dev@gmail.com","subject":"Re: [PATCH] comment: fix a typo in the comment","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-06T16:04:50Z","receivedAt":"2017-07-06T16:04:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"SZEDER Gábor <szeder.dev@gmail.com> writes:\n\n> Speaking of sharp eyes...  That Subject: line really needs a\n> s/comment:/commit:/, doesn't it? :)\n\nSurely it does.\n"},{"id":"323959","messageId":"20170707160248.9611-1-kaarticsivaraam91196@gmail.com","threadId":"46314","inReplyTo":"xmqqtw2pft5p.fsf@gitster.mtv.corp.google.com","subject":"[PATCH] commit: fix a typo in the comment","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-07-07T16:02:48Z","receivedAt":"2017-07-07T16:02:59Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>\n---\n builtin/commit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 8d1cac062..aff6bf7aa 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)\n \tint i, eol;\n \tconst char *nl;\n \n-\t/* Check if the rest is just whitespace and Signed-of-by's. */\n+\t/* Check if the rest is just whitespace and Signed-off-by's. */\n \tfor (i = start; i < sb->len; i++) {\n \t\tnl = memchr(sb->buf + i, '\\n', sb->len - i);\n \t\tif (nl)\n-- \n2.13.2.879.g2ab69f31a.dirty\n\n"}]}