# [PATCH] comment: fix a typo in the comment 7 messages from 2017-07-05 to 2017-07-07. Participants: Kaartic Sivaraam, Junio C Hamano, SZEDER Gábor. Thread: https://gitlist.dev/t/46314 ## Kaartic Sivaraam, 2017-07-05 17:03 Subject: [PATCH] comment: fix a typo in the comment Message-ID: <20170705170324.21026-1-kaarticsivaraam91196@gmail.com> URL: https://gitlist.dev/e/20170705170324.21026-1-kaarticsivaraam91196%40gmail.com ``` --- Though very trivial, I wanted to correct this as I didn't want to ignore it after seeing it. builtin/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/commit.c b/builtin/commit.c index 8d1cac0..aff6bf7 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start) int i, eol; const char *nl; - /* Check if the rest is just whitespace and Signed-of-by's. */ + /* Check if the rest is just whitespace and Signed-off-by's. */ for (i = start; i < sb->len; i++) { nl = memchr(sb->buf + i, '\n', sb->len - i); if (nl) -- 2.7.4 ``` ## Junio C Hamano, 2017-07-05 18:18 Subject: Re: [PATCH] comment: fix a typo in the comment Message-ID: URL: https://gitlist.dev/e/xmqq8tk2iw87.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170705170324.21026-1-kaarticsivaraam91196@gmail.com> ``` Kaartic Sivaraam writes: > --- > Though very trivial, I wanted to correct this as I didn't > want to ignore it after seeing it. Thanks for sharp eyes. Sign-off? (or Sign-of? ;-)) > > builtin/commit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/commit.c b/builtin/commit.c > index 8d1cac0..aff6bf7 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start) > int i, eol; > const char *nl; > > - /* Check if the rest is just whitespace and Signed-of-by's. */ > + /* Check if the rest is just whitespace and Signed-off-by's. */ > for (i = start; i < sb->len; i++) { > nl = memchr(sb->buf + i, '\n', sb->len - i); > if (nl) ``` ## Kaartic Sivaraam, 2017-07-06 03:17 Subject: Re: [PATCH] comment: fix a typo in the comment Message-ID: <1499311044.1776.1.camel@gmail.com> URL: https://gitlist.dev/e/1499311044.1776.1.camel%40gmail.com In-Reply-To: ``` On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > > --- > >  Though very trivial, I wanted to correct this as I didn't > >  want to ignore it after seeing it. > > Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-)) > I should also thank you for your sharp eyes! BTW, this won't repeat again as I have made 'git' worry about adding the signed-off-by to the commits I do on my local version of git.git :) -- Kaartic ``` ## Kaartic Sivaraam, 2017-07-06 03:19 Subject: [PATCH] comment: fix a typo in the comment Message-ID: <20170706031957.5782-1-kaarticsivaraam91196@gmail.com> URL: https://gitlist.dev/e/20170706031957.5782-1-kaarticsivaraam91196%40gmail.com In-Reply-To: ``` Signed-off-by: Kaartic Sivaraam --- builtin/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/commit.c b/builtin/commit.c index 8d1cac062..aff6bf7aa 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start) int i, eol; const char *nl; - /* Check if the rest is just whitespace and Signed-of-by's. */ + /* Check if the rest is just whitespace and Signed-off-by's. */ for (i = start; i < sb->len; i++) { nl = memchr(sb->buf + i, '\n', sb->len - i); if (nl) -- 2.11.0 ``` ## SZEDER Gábor, 2017-07-06 14:47 Subject: Re: [PATCH] comment: fix a typo in the comment Message-ID: <20170706144711.31002-1-szeder.dev@gmail.com> URL: https://gitlist.dev/e/20170706144711.31002-1-szeder.dev%40gmail.com In-Reply-To: <1499311044.1776.1.camel@gmail.com> ``` > On Wed, 2017-07-05 at 11:18 -0700, Junio C Hamano wrote: > > Kaartic Sivaraam writes: > > > > > --- > > > �Though very trivial, I wanted to correct this as I didn't > > > �want to ignore it after seeing it. > > > > Thanks for sharp eyes.��Sign-off?��(or Sign-of? ;-)) > > > I should also thank you for your sharp eyes! Speaking of sharp eyes... That Subject: line really needs a s/comment:/commit:/, doesn't it? :) ``` ## Junio C Hamano, 2017-07-06 16:04 Subject: Re: [PATCH] comment: fix a typo in the comment Message-ID: URL: https://gitlist.dev/e/xmqqtw2pft5p.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20170706144711.31002-1-szeder.dev@gmail.com> ``` SZEDER Gábor writes: > Speaking of sharp eyes... That Subject: line really needs a > s/comment:/commit:/, doesn't it? :) Surely it does. ``` ## Kaartic Sivaraam, 2017-07-07 16:02 Subject: [PATCH] commit: fix a typo in the comment Message-ID: <20170707160248.9611-1-kaarticsivaraam91196@gmail.com> URL: https://gitlist.dev/e/20170707160248.9611-1-kaarticsivaraam91196%40gmail.com In-Reply-To: ``` Signed-off-by: Kaartic Sivaraam --- builtin/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/commit.c b/builtin/commit.c index 8d1cac062..aff6bf7aa 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start) int i, eol; const char *nl; - /* Check if the rest is just whitespace and Signed-of-by's. */ + /* Check if the rest is just whitespace and Signed-off-by's. */ for (i = start; i < sb->len; i++) { nl = memchr(sb->buf + i, '\n', sb->len - i); if (nl) -- 2.13.2.879.g2ab69f31a.dirty ```