threads / patch / 46220

patchstatus tests: fix a minor indenting issue

Subject: [PATCH] status tests: fix a minor indenting issue

## tl;dr

3 messages between Jun 21, 2017 and Jun 21, 2017. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Kaartic Sivaraam· Jun 21, 2017, 12:31 UTC · lore

Change the indentation from "\t " to "\t". This indenting issue was introduced when the test was added in commit 1d2f393ac9 ("status/commit: show staged submodules regardless of ignore config", 2014-04-05).

Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t7508-status.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t7508-status.sh +1 −2

diff --git a/t/t7508-status.sh b/t/t7508-status.sh
index 5edcc6edf..35ea0b707 100755
--- a/t/t7508-status.sh
+++ b/t/t7508-status.sh
@@ -1494,7 +1494,7 @@ EOF
 test_expect_success 'git commit -m will commit a staged but ignored
submodule' '
 	git commit -uno -m message &&
 	git status -s --ignore-submodules=dirty >output &&
-	 test_i18ngrep ! "^M. sm" output &&
+	test_i18ngrep ! "^M. sm" output &&
 	git config --remove-section submodule.subname &&
 	git config -f .gitmodules  --remove-section submodule.subname
 '
-- 
2.11.0

Junio C Hamano· Jun 21, 2017, 16:34 UTC · re: Kaartic Sivaraam · lore

Re: [PATCH] status tests: fix a minor indenting issue

Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:

Show 28 quoted lines

> Change the indentation from "\t " to "\t". This indenting issue was
> introduced when the test was added in commit
> 1d2f393ac9 ("status/commit: show staged submodules regardless of
> ignore config", 2014-04-05).
>
> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t7508-status.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index 5edcc6edf..35ea0b707 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -1494,7 +1494,7 @@ EOF
>  test_expect_success 'git commit -m will commit a staged but ignored
> submodule' '
>  	git commit -uno -m message &&
>  	git status -s --ignore-submodules=dirty >output &&
> -	 test_i18ngrep ! "^M. sm" output &&
> +	test_i18ngrep ! "^M. sm" output &&
>  	git config --remove-section submodule.subname &&
>  	git config -f .gitmodules  --remove-section submodule.subname
>  '
> -- 
> 2.11.0

Your patch is heavily whitespace damaged, line-wrapped and full of <A0> (nbsp??) bytes as can be seen by downloading from

http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/raw

I'll hand-tweak to make it apply, so no need to resend but please make sure you can send your patches cleanly before sending a more substantial patch.

Thanks.

Kaartic Sivaraam· Jun 21, 2017, 18:18 UTC · re: Junio C Hamano · lore

Re: [PATCH] status tests: fix a minor indenting issue

On Wed, 2017-06-21 at 09:34 -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Your patch is heavily whitespace damaged, line-wrapped and
> full of <A0> (nbsp??) bytes as can be seen by downloading from
> 
> http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/r
> aw
> 
> I'll hand-tweak to make it apply, so no need to resend but please
> make sure you can send your patches cleanly before sending a more
> substantial patch.
> 
> Thanks.
>

Sorry about that. As specified in another thread, will be careful about sending patches through email-clients in future.

-- 
Regards,
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>