git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] status tests: fix a minor indenting issue

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 21, 2017, 16:34 UTC
Message-ID
<xmqqwp85qozf.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1498048305.1746.6.camel@gmail.com>
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
Show 28 quoted lines
> Change the indentation from "\t " to "\t". This indenting issue was
> introduced when the test was added in commit
> 1d2f393ac9 ("status/commit: show staged submodules regardless of
> ignore config", 2014-04-05).
>
> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t7508-status.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index 5edcc6edf..35ea0b707 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -1494,7 +1494,7 @@ EOF
>  test_expect_success 'git commit -m will commit a staged but ignored
> submodule' '
>  	git commit -uno -m message &&
>  	git status -s --ignore-submodules=dirty >output &&
> -	 test_i18ngrep ! "^M. sm" output &&
> +	test_i18ngrep ! "^M. sm" output &&
>  	git config --remove-section submodule.subname &&
>  	git config -f .gitmodules  --remove-section submodule.subname
>  '
> -- 
> 2.11.0

Your patch is heavily whitespace damaged, line-wrapped and full of <A0> (nbsp??) bytes as can be seen by downloading from

http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/raw

I'll hand-tweak to make it apply, so no need to resend but please make sure you can send your patches cleanly before sending a more substantial patch.

Thanks.
Previous: Kaartic SivaraamNext: Kaartic Sivaraam
Message 2 of 3 in “status tests: fix a minor indenting issue”
  1. status tests: fix a minor indenting issueKaartic Sivaraam, Jun 21, 2017
  2. Junio C HamanoJun 21, 2017
  3. Kaartic SivaraamJun 21, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.