{"thread":{"id":"46220","subject":"[PATCH] status tests: fix a minor indenting issue","startedAt":"2017-06-21T12:32:02Z","lastAt":"2017-06-21T18:18:50Z","messageCount":3,"participants":["Kaartic Sivaraam","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"322805","messageId":"1498048305.1746.6.camel@gmail.com","threadId":"46220","inReplyTo":null,"subject":"[PATCH] status tests: fix a minor indenting issue","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-06-21T12:31:45Z","receivedAt":"2017-06-21T12:32:02Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"Change the indentation from \"\\t \" to \"\\t\". This indenting issue was\nintroduced when the test was added in commit\n1d2f393ac9 (\"status/commit: show staged submodules regardless of\nignore config\", 2014-04-05).\n\nHelped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/t7508-status.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7508-status.sh b/t/t7508-status.sh\nindex 5edcc6edf..35ea0b707 100755\n--- a/t/t7508-status.sh\n+++ b/t/t7508-status.sh\n@@ -1494,7 +1494,7 @@ EOF\n test_expect_success 'git commit -m will commit a staged but ignored\nsubmodule' '\n \tgit commit -uno -m message &&\n \tgit status -s --ignore-submodules=dirty >output &&\n-\t test_i18ngrep ! \"^M. sm\" output &&\n+\ttest_i18ngrep ! \"^M. sm\" output &&\n \tgit config --remove-section submodule.subname &&\n \tgit config -f .gitmodules  --remove-section submodule.subname\n '\n-- \n2.11.0\n"},{"id":"322817","messageId":"xmqqwp85qozf.fsf@gitster.mtv.corp.google.com","threadId":"46220","inReplyTo":"1498048305.1746.6.camel@gmail.com","subject":"Re: [PATCH] status tests: fix a minor indenting issue","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-21T16:34:12Z","receivedAt":"2017-06-21T16:34:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:\n\n> Change the indentation from \"\\t \" to \"\\t\". This indenting issue was\n> introduced when the test was added in commit\n> 1d2f393ac9 (\"status/commit: show staged submodules regardless of\n> ignore config\", 2014-04-05).\n>\n> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>\n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n>  t/t7508-status.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t7508-status.sh b/t/t7508-status.sh\n> index 5edcc6edf..35ea0b707 100755\n> --- a/t/t7508-status.sh\n> +++ b/t/t7508-status.sh\n> @@ -1494,7 +1494,7 @@ EOF\n>  test_expect_success 'git commit -m will commit a staged but ignored\n> submodule' '\n>  \tgit commit -uno -m message &&\n>  \tgit status -s --ignore-submodules=dirty >output &&\n> -\t test_i18ngrep ! \"^M. sm\" output &&\n> +\ttest_i18ngrep ! \"^M. sm\" output &&\n>  \tgit config --remove-section submodule.subname &&\n>  \tgit config -f .gitmodules  --remove-section submodule.subname\n>  '\n> -- \n> 2.11.0\n\nYour patch is heavily whitespace damaged, line-wrapped and\nfull of <A0> (nbsp??) bytes as can be seen by downloading from\n\nhttp://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/raw\n\nI'll hand-tweak to make it apply, so no need to resend but please\nmake sure you can send your patches cleanly before sending a more\nsubstantial patch.\n\nThanks.\n\n"},{"id":"322834","messageId":"1498069113.32360.12.camel@gmail.com","threadId":"46220","inReplyTo":"xmqqwp85qozf.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] status tests: fix a minor indenting issue","fromName":"Kaartic Sivaraam","fromEmail":"kaarticsivaraam91196@gmail.com","sentAt":"2017-06-21T18:18:33Z","receivedAt":"2017-06-21T18:18:50Z","isPatch":true,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"On Wed, 2017-06-21 at 09:34 -0700, Junio C Hamano wrote:\n> Your patch is heavily whitespace damaged, line-wrapped and\n> full of <A0> (nbsp??) bytes as can be seen by downloading from\n> \n> http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/r\n> aw\n> \n> I'll hand-tweak to make it apply, so no need to resend but please\n> make sure you can send your patches cleanly before sending a more\n> substantial patch.\n> \n> Thanks.\n> \nSorry about that. As specified in another thread, will be careful about\nsending patches through email-clients in future.\n\n-- \nRegards,\nKaartic Sivaraam <kaarticsivaraam91196@gmail.com>\n"}]}