threads / patch / 46055

patchwildmatch test: cover a blind spot in "/" matching

Subject: [PATCH] wildmatch test: cover a blind spot in "/" matching

## tl;dr

5 messages between May 27, 2017 and Jun 10, 2017. Diffs are folded; open one to read it.

replies: 4people: 2as markdown or json

Ævar Arnfjörð Bjarmason· May 27, 2017, 09:13 UTC · lore

Add a test which covers a blindspot in how these tests should assert that negated character classes are allowed or not allowed to match "/" in certain circumstances.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t3070-wildmatch.sh | 2 ++
 1 file changed, 2 insertions(+)
Show changes to t/t3070-wildmatch.sh +2 −1
diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index ef509df35160..65ea07b68356 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'
 match 1 0 'foo/bar' 'foo/**/**/bar'
 match 0 0 'foo/bar' 'foo?bar'
 match 0 0 'foo/bar' 'foo[/]bar'
+match 0 0 'foo/bar' 'foo[^a-z]bar'
 match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
 match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
 match 1 0 'foo' '**/foo'
@@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'
 pathmatch 0 foo/bba/arr 'foo/**z'
 pathmatch 1 foo/bar 'foo?bar'
 pathmatch 1 foo/bar 'foo[/]bar'
+pathmatch 1 foo/bar 'foo[^a-z]bar'
 pathmatch 0 foo '*/*/*'
 pathmatch 0 foo/bar '*/*/*'
 pathmatch 1 foo/bba/arr '*/*/*'

--
https://github.com/git/git/pull/362
Ævar Arnfjörð Bjarmason· Jun 9, 2017, 16:21 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

On Sat, May 27, 2017 at 11:13 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> Add a test which covers a blindspot in how these tests should assert
> that negated character classes are allowed or not allowed to match "/"
> in certain circumstances.
Junio: I didn't CC you on this, because I probably clicked some wrong
option in submitgit which I was testing for this patch. Could you
please queue this one?
Show 28 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t3070-wildmatch.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
> index ef509df35160..65ea07b68356 100755
> --- a/t/t3070-wildmatch.sh
> +++ b/t/t3070-wildmatch.sh
> @@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'
>  match 1 0 'foo/bar' 'foo/**/**/bar'
>  match 0 0 'foo/bar' 'foo?bar'
>  match 0 0 'foo/bar' 'foo[/]bar'
> +match 0 0 'foo/bar' 'foo[^a-z]bar'
>  match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
>  match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
>  match 1 0 'foo' '**/foo'
> @@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'
>  pathmatch 0 foo/bba/arr 'foo/**z'
>  pathmatch 1 foo/bar 'foo?bar'
>  pathmatch 1 foo/bar 'foo[/]bar'
> +pathmatch 1 foo/bar 'foo[^a-z]bar'
>  pathmatch 0 foo '*/*/*'
>  pathmatch 0 foo/bar '*/*/*'
>  pathmatch 1 foo/bba/arr '*/*/*'
>
> --
> https://github.com/git/git/pull/362
Junio C Hamano· Jun 10, 2017, 01:55 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
> Add a test which covers a blindspot in how these tests should assert
> that negated character classes are allowed or not allowed to match "/"
> in certain circumstances.
Please make this a bit more explicit, something like
	A negated character class that does not include '/',
	e.g. [^a-z],
        - should match '/' when doing "wildmatch"
	- should not match '/' when doing "pathmatch"
	Add two tests to cover these cases.
Thanks.
Show 28 quoted lines
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t3070-wildmatch.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
> index ef509df35160..65ea07b68356 100755
> --- a/t/t3070-wildmatch.sh
> +++ b/t/t3070-wildmatch.sh
> @@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'
>  match 1 0 'foo/bar' 'foo/**/**/bar'
>  match 0 0 'foo/bar' 'foo?bar'
>  match 0 0 'foo/bar' 'foo[/]bar'
> +match 0 0 'foo/bar' 'foo[^a-z]bar'
>  match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
>  match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'
>  match 1 0 'foo' '**/foo'
> @@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'
>  pathmatch 0 foo/bba/arr 'foo/**z'
>  pathmatch 1 foo/bar 'foo?bar'
>  pathmatch 1 foo/bar 'foo[/]bar'
> +pathmatch 1 foo/bar 'foo[^a-z]bar'
>  pathmatch 0 foo '*/*/*'
>  pathmatch 0 foo/bar '*/*/*'
>  pathmatch 1 foo/bba/arr '*/*/*'
>
> --
> https://github.com/git/git/pull/362
Junio C Hamano· Jun 10, 2017, 01:57 UTC · re: Junio C Hamano · lore

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> Add a test which covers a blindspot in how these tests should assert
>> that negated character classes are allowed or not allowed to match "/"
>> in certain circumstances.
>
> Please make this a bit more explicit, something like
>
> 	A negated character class that does not include '/',
> 	e.g. [^a-z],

oops. I think the class includes '/'; please excuse loose logic in a "something like" meant as an illustration to show the level of details expected ;-)

Ævar Arnfjörð Bjarmason· Jun 10, 2017, 11:31 UTC · re: Junio C Hamano · lore

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

On Sat, Jun 10 2017, Junio C. Hamano jotted:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>>
>>> Add a test which covers a blindspot in how these tests should assert
>>> that negated character classes are allowed or not allowed to match "/"
>>> in certain circumstances.
>>
>> Please make this a bit more explicit, something like
>>
>> 	A negated character class that does not include '/',
>> 	e.g. [^a-z],
>
> oops.  I think the class includes '/'; please excuse loose logic in
> a "something like" meant as an illustration to show the level of
> details expected ;-)

Thanks for the feedback. Sorry I'm slightly confused still (after reading this over a couple of times), are you OK with this patch/commit message as-is or would you still like some clarification there?

← back to recent threads