git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] wildmatch test: cover a blind spot in "/" matching

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jun 10, 2017, 11:31 UTC
Message-ID
<87wp8krsde.fsf@gmail.com>
In-Reply-To
<xmqqh8zo4na3.fsf@gitster.mtv.corp.google.com>
On Sat, Jun 10 2017, Junio C. Hamano jotted:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>>
>>> Add a test which covers a blindspot in how these tests should assert
>>> that negated character classes are allowed or not allowed to match "/"
>>> in certain circumstances.
>>
>> Please make this a bit more explicit, something like
>>
>> 	A negated character class that does not include '/',
>> 	e.g. [^a-z],
>
> oops.  I think the class includes '/'; please excuse loose logic in
> a "something like" meant as an illustration to show the level of
> details expected ;-)

Thanks for the feedback. Sorry I'm slightly confused still (after reading this over a couple of times), are you OK with this patch/commit message as-is or would you still like some clarification there?

Previous: Junio C Hamano
Message 5 of 5 in “wildmatch test: cover a blind spot in "/" matching”
  1. wildmatch test: cover a blind spot in "/" matchingÆvar Arnfjörð Bjarmason, May 27, 2017
  2. Ævar Arnfjörð BjarmasonJun 9, 2017
  3. Junio C HamanoJun 10, 2017
  4. Junio C HamanoJun 10, 2017
  5. Ævar Arnfjörð BjarmasonJun 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.