{"thread":{"id":"46055","subject":"[PATCH] wildmatch test: cover a blind spot in \"/\" matching","startedAt":"2017-05-27T09:13:07Z","lastAt":"2017-06-10T11:31:52Z","messageCount":5,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"320864","messageId":"0102015c492e27c6-669f7ca8-e7c6-484f-9c5b-7cb9358ee966-000000@eu-west-1.amazonses.com","threadId":"46055","inReplyTo":null,"subject":"[PATCH] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-05-27T09:13:00Z","receivedAt":"2017-05-27T09:13:07Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Add a test which covers a blindspot in how these tests should assert\nthat negated character classes are allowed or not allowed to match \"/\"\nin certain circumstances.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n t/t3070-wildmatch.sh | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh\nindex ef509df35160..65ea07b68356 100755\n--- a/t/t3070-wildmatch.sh\n+++ b/t/t3070-wildmatch.sh\n@@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'\n match 1 0 'foo/bar' 'foo/**/**/bar'\n match 0 0 'foo/bar' 'foo?bar'\n match 0 0 'foo/bar' 'foo[/]bar'\n+match 0 0 'foo/bar' 'foo[^a-z]bar'\n match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n match 1 0 'foo' '**/foo'\n@@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'\n pathmatch 0 foo/bba/arr 'foo/**z'\n pathmatch 1 foo/bar 'foo?bar'\n pathmatch 1 foo/bar 'foo[/]bar'\n+pathmatch 1 foo/bar 'foo[^a-z]bar'\n pathmatch 0 foo '*/*/*'\n pathmatch 0 foo/bar '*/*/*'\n pathmatch 1 foo/bba/arr '*/*/*'\n\n--\nhttps://github.com/git/git/pull/362\n"},{"id":"321836","messageId":"CACBZZX44Wc1c2RXfnZMu4cX8NAkdyuaktxZpCWcWK83oiJ2iRQ@mail.gmail.com","threadId":"46055","inReplyTo":"0102015c492e27c6-669f7ca8-e7c6-484f-9c5b-7cb9358ee966-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-06-09T16:21:37Z","receivedAt":"2017-06-09T16:22:04Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, May 27, 2017 at 11:13 AM, Ævar Arnfjörð Bjarmason\n wrote:\n> Add a test which covers a blindspot in how these tests should assert\n> that negated character classes are allowed or not allowed to match \"/\"\n> in certain circumstances.\n\nJunio: I didn't CC you on this, because I probably clicked some wrong\noption in submitgit which I was testing for this patch. Could you\nplease queue this one?\n\n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> t/t3070-wildmatch.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh\n> index ef509df35160..65ea07b68356 100755\n> --- a/t/t3070-wildmatch.sh\n> +++ b/t/t3070-wildmatch.sh\n> @@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'\n> match 1 0 'foo/bar' 'foo/**/**/bar'\n> match 0 0 'foo/bar' 'foo?bar'\n> match 0 0 'foo/bar' 'foo[/]bar'\n> +match 0 0 'foo/bar' 'foo[^a-z]bar'\n> match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n> match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n> match 1 0 'foo' '**/foo'\n> @@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'\n> pathmatch 0 foo/bba/arr 'foo/**z'\n> pathmatch 1 foo/bar 'foo?bar'\n> pathmatch 1 foo/bar 'foo[/]bar'\n> +pathmatch 1 foo/bar 'foo[^a-z]bar'\n> pathmatch 0 foo '*/*/*'\n> pathmatch 0 foo/bar '*/*/*'\n> pathmatch 1 foo/bba/arr '*/*/*'\n>\n> --\n> https://github.com/git/git/pull/362\n"},{"id":"321870","messageId":"xmqqlgp04ne3.fsf@gitster.mtv.corp.google.com","threadId":"46055","inReplyTo":"0102015c492e27c6-669f7ca8-e7c6-484f-9c5b-7cb9358ee966-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-10T01:55:32Z","receivedAt":"2017-06-10T01:55:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> Add a test which covers a blindspot in how these tests should assert\n> that negated character classes are allowed or not allowed to match \"/\"\n> in certain circumstances.\n\nPlease make this a bit more explicit, something like\n\n\tA negated character class that does not include '/',\n\te.g. [^a-z],\n\n - should match '/' when doing \"wildmatch\"\n\t- should not match '/' when doing \"pathmatch\"\n\n\tAdd two tests to cover these cases.\n\nThanks.\n\n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> t/t3070-wildmatch.sh | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh\n> index ef509df35160..65ea07b68356 100755\n> --- a/t/t3070-wildmatch.sh\n> +++ b/t/t3070-wildmatch.sh\n> @@ -82,6 +82,7 @@ match 1 0 'foo/bar' 'foo/**/bar'\n> match 1 0 'foo/bar' 'foo/**/**/bar'\n> match 0 0 'foo/bar' 'foo?bar'\n> match 0 0 'foo/bar' 'foo[/]bar'\n> +match 0 0 'foo/bar' 'foo[^a-z]bar'\n> match 0 0 'foo/bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n> match 1 1 'foo-bar' 'f[^eiu][^eiu][^eiu][^eiu][^eiu]r'\n> match 1 0 'foo' '**/foo'\n> @@ -226,6 +227,7 @@ pathmatch 0 foo/bba/arr 'foo/*z'\n> pathmatch 0 foo/bba/arr 'foo/**z'\n> pathmatch 1 foo/bar 'foo?bar'\n> pathmatch 1 foo/bar 'foo[/]bar'\n> +pathmatch 1 foo/bar 'foo[^a-z]bar'\n> pathmatch 0 foo '*/*/*'\n> pathmatch 0 foo/bar '*/*/*'\n> pathmatch 1 foo/bba/arr '*/*/*'\n>\n> --\n> https://github.com/git/git/pull/362\n"},{"id":"321871","messageId":"xmqqh8zo4na3.fsf@gitster.mtv.corp.google.com","threadId":"46055","inReplyTo":"xmqqlgp04ne3.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-10T01:57:56Z","receivedAt":"2017-06-10T01:58:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Ævar Arnfjörð Bjarmason writes:\n>\n>> Add a test which covers a blindspot in how these tests should assert\n>> that negated character classes are allowed or not allowed to match \"/\"\n>> in certain circumstances.\n>\n> Please make this a bit more explicit, something like\n>\n> \tA negated character class that does not include '/',\n> \te.g. [^a-z],\n\noops. I think the class includes '/'; please excuse loose logic in\na \"something like\" meant as an illustration to show the level of\ndetails expected ;-)\n"},{"id":"321914","messageId":"87wp8krsde.fsf@gmail.com","threadId":"46055","inReplyTo":"xmqqh8zo4na3.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] wildmatch test: cover a blind spot in \"/\" matching","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-06-10T11:31:41Z","receivedAt":"2017-06-10T11:31:52Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Sat, Jun 10 2017, Junio C. Hamano jotted:\n\n> Junio C Hamano writes:\n>\n>> Ævar Arnfjörð Bjarmason writes:\n>>\n>>> Add a test which covers a blindspot in how these tests should assert\n>>> that negated character classes are allowed or not allowed to match \"/\"\n>>> in certain circumstances.\n>>\n>> Please make this a bit more explicit, something like\n>>\n>> \tA negated character class that does not include '/',\n>> \te.g. [^a-z],\n>\n> oops. I think the class includes '/'; please excuse loose logic in\n> a \"something like\" meant as an illustration to show the level of\n> details expected ;-)\n\nThanks for the feedback. Sorry I'm slightly confused still (after\nreading this over a couple of times), are you OK with this patch/commit\nmessage as-is or would you still like some clarification there?\n"}]}