threads / patch / 45860

patchconfig.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Subject: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

## tl;dr

4 messages between May 3, 2017 and May 3, 2017. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Ævar Arnfjörð Bjarmason· May 3, 2017, 13:54 UTC · lore

Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.

Since commit 2f8952250a ("regex: add regexec_buf() that can work on a non NUL-terminated string", 2016-09-21) git has errored out at compile-time if the regular expression library doesn't support REG_STARTEND.

While looking through Google search results for the use of NO_REGEX I
found a Chef recipe that set this on AIX[1], looking through the
documentation for the latest version of AIX (7.2, released October
2015) shows that its regexec() doesn't have REG_STARTEND.

1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)

Show changes to config.mak.uname +1 −0

diff --git a/config.mak.uname b/config.mak.uname
index 399fe19271..192629f143 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -237,6 +237,7 @@ ifeq ($(uname_S),AIX)
 	NO_MKDTEMP = YesPlease
 	NO_STRLCPY = YesPlease
 	NO_NSEC = YesPlease
+	NO_REGEX = NeedsStartEnd
 	FREAD_READS_DIRECTORIES = UnfortunatelyYes
 	INTERNAL_QSORT = UnfortunatelyYes
 	NEEDS_LIBICONV = YesPlease

-- 
2.11.0

Jonathan Nieder· May 3, 2017, 19:47 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Ævar Arnfjörð Bjarmason wrote:

Show 19 quoted lines

> Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.
>
> Since commit 2f8952250a ("regex: add regexec_buf() that can work on a
> non NUL-terminated string", 2016-09-21) git has errored out at
> compile-time if the regular expression library doesn't support
> REG_STARTEND.
>
> While looking through Google search results for the use of NO_REGEX I
> found a Chef recipe that set this on AIX[1], looking through the
> documentation for the latest version of AIX (7.2, released October
> 2015) shows that its regexec() doesn't have REG_STARTEND.
>
> 1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
> 2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)

Thanks.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Is there e.g. a build farm where we can check for this kind of thing more systematically on supported platforms?

Stefan Beller· May 3, 2017, 20:00 UTC · re: Jonathan Nieder · lore

Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

>
> Is there e.g. a build farm where we can check for this kind of thing
> more systematically on supported platforms?

There is the OpenSuse build farm that provides builds for all kinds of linux distributions, though we'd rather be looking for *all* operating systems, not just various flavors of linux.

After some research, I found https://gcc.gnu.org/wiki/CompileFarm https://launchpad.net/builders https://buildd.debian.org/

The gcc build farm would include AIX, maybe we could talk to them to have more CI support on more platforms?

Also you're a DD, maybe we could hook up git testing on debian to test for different hardware platforms?

Thanks, Stefan

Jonathan Nieder· May 3, 2017, 20:04 UTC · re: Stefan Beller · lore

Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

Hi,

Stefan Beller wrote:

> On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 14 quoted lines

>> Is there e.g. a build farm where we can check for this kind of thing
>> more systematically on supported platforms?
>
> There is the OpenSuse build farm that provides builds for all kinds of
> linux distributions, though we'd rather be looking for *all*
> operating systems, not just various flavors of linux.
>
> After some research, I found
> https://gcc.gnu.org/wiki/CompileFarm
> https://launchpad.net/builders
> https://buildd.debian.org/
>
> The gcc build farm would include AIX, maybe we could talk to
> them to have more CI support on more platforms?

Thanks for the pointers.

> Also you're a DD, maybe we could hook up git testing on debian
> to test for different hardware platforms?

https://buildd.debian.org/status/package.php?p=git&suite=experimental shows test suite results for Debian's various platforms running "next".

Hope that helps, Jonathan