Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 3, 2017, 19:47 UTC
Message-ID: <20170503194708.GE28740@aiede.svl.corp.google.com>
In-Reply-To: <20170503135430.7785-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 19 quoted lines

> Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.
>
> Since commit 2f8952250a ("regex: add regexec_buf() that can work on a
> non NUL-terminated string", 2016-09-21) git has errored out at
> compile-time if the regular expression library doesn't support
> REG_STARTEND.
>
> While looking through Google search results for the use of NO_REGEX I
> found a Chef recipe that set this on AIX[1], looking through the
> documentation for the latest version of AIX (7.2, released October
> 2015) shows that its regexec() doesn't have REG_STARTEND.
>
> 1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47
> 2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)

Thanks.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Is there e.g. a build farm where we can check for this kind of thing more systematically on supported platforms?