{"thread":{"id":"45860","subject":"[PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX","startedAt":"2017-05-03T13:55:11Z","lastAt":"2017-05-03T20:04:45Z","messageCount":4,"participants":["Ævar Arnfjörð Bjarmason","Jonathan Nieder","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"318649","messageId":"20170503135430.7785-1-avarab@gmail.com","threadId":"45860","inReplyTo":null,"subject":"[PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2017-05-03T13:54:30Z","receivedAt":"2017-05-03T13:55:11Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.\n\nSince commit 2f8952250a (\"regex: add regexec_buf() that can work on a\nnon NUL-terminated string\", 2016-09-21) git has errored out at\ncompile-time if the regular expression library doesn't support\nREG_STARTEND.\n\nWhile looking through Google search results for the use of NO_REGEX I\nfound a Chef recipe that set this on AIX[1], looking through the\ndocumentation for the latest version of AIX (7.2, released October\n2015) shows that its regexec() doesn't have REG_STARTEND.\n\n1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47\n2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n config.mak.uname | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 399fe19271..192629f143 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -237,6 +237,7 @@ ifeq ($(uname_S),AIX)\n \tNO_MKDTEMP = YesPlease\n \tNO_STRLCPY = YesPlease\n \tNO_NSEC = YesPlease\n+\tNO_REGEX = NeedsStartEnd\n \tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n \tINTERNAL_QSORT = UnfortunatelyYes\n \tNEEDS_LIBICONV = YesPlease\n-- \n2.11.0\n\n"},{"id":"318691","messageId":"20170503194708.GE28740@aiede.svl.corp.google.com","threadId":"45860","inReplyTo":"20170503135430.7785-1-avarab@gmail.com","subject":"Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-05-03T19:47:08Z","receivedAt":"2017-05-03T19:47:19Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ævar Arnfjörð Bjarmason wrote:\n\n> Set the NO_REGEX=NeedsStartEnd Makefile flag by default on AIX.\n>\n> Since commit 2f8952250a (\"regex: add regexec_buf() that can work on a\n> non NUL-terminated string\", 2016-09-21) git has errored out at\n> compile-time if the regular expression library doesn't support\n> REG_STARTEND.\n>\n> While looking through Google search results for the use of NO_REGEX I\n> found a Chef recipe that set this on AIX[1], looking through the\n> documentation for the latest version of AIX (7.2, released October\n> 2015) shows that its regexec() doesn't have REG_STARTEND.\n>\n> 1. https://github.com/chef/omnibus-software/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47\n> 2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm\n>\n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n> config.mak.uname | 1 +\n> 1 file changed, 1 insertion(+)\n\nThanks.\n\nReviewed-by: Jonathan Nieder \n\nIs there e.g. a build farm where we can check for this kind of thing\nmore systematically on supported platforms?\n"},{"id":"318695","messageId":"CAGZ79kZHhAsoWKhGHfccspikANjK7z=Zdh1us8r1+hw+4kHUHg@mail.gmail.com","threadId":"45860","inReplyTo":"20170503194708.GE28740@aiede.svl.corp.google.com","subject":"Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-05-03T20:00:31Z","receivedAt":"2017-05-03T20:00:46Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder wrote:\n>\n> Is there e.g. a build farm where we can check for this kind of thing\n> more systematically on supported platforms?\n\nThere is the OpenSuse build farm that provides builds for all kinds of\nlinux distributions, though we'd rather be looking for *all*\noperating systems, not just various flavors of linux.\n\nAfter some research, I found\nhttps://gcc.gnu.org/wiki/CompileFarm\nhttps://launchpad.net/builders\nhttps://buildd.debian.org/\n\nThe gcc build farm would include AIX, maybe we could talk to\nthem to have more CI support on more platforms?\n\nAlso you're a DD, maybe we could hook up git testing on debian\nto test for different hardware platforms?\n\nThanks,\nStefan\n"},{"id":"318697","messageId":"20170503200434.GF28740@aiede.svl.corp.google.com","threadId":"45860","inReplyTo":"CAGZ79kZHhAsoWKhGHfccspikANjK7z=Zdh1us8r1+hw+4kHUHg@mail.gmail.com","subject":"Re: [PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-05-03T20:04:34Z","receivedAt":"2017-05-03T20:04:45Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nStefan Beller wrote:\n> On Wed, May 3, 2017 at 12:47 PM, Jonathan Nieder wrote:\n\n>> Is there e.g. a build farm where we can check for this kind of thing\n>> more systematically on supported platforms?\n>\n> There is the OpenSuse build farm that provides builds for all kinds of\n> linux distributions, though we'd rather be looking for *all*\n> operating systems, not just various flavors of linux.\n>\n> After some research, I found\n> https://gcc.gnu.org/wiki/CompileFarm\n> https://launchpad.net/builders\n> https://buildd.debian.org/\n>\n> The gcc build farm would include AIX, maybe we could talk to\n> them to have more CI support on more platforms?\n\nThanks for the pointers.\n\n> Also you're a DD, maybe we could hook up git testing on debian\n> to test for different hardware platforms?\n\nhttps://buildd.debian.org/status/package.php?p=git&suite=experimental\nshows test suite results for Debian's various platforms running \"next\".\n\nHope that helps,\nJonathan\n"}]}