invalid command name "listrefs"

Junio C Hamano· Jun 11, 2006, 16:50 UTC · lore

Starting gitk, "File->Reread references" results in an error dialog.

This patch resurrects the procedure from an older version, and it seems to work for me, but with the updated code it might be that you wanted to use a different mechanism to implement rereadrefs procedure -- I dunno.

-- >8 -- gitk: rereadrefs wants listrefs

The listrefs procedure was removed during the course of development, but there is still a user of it, so resurrect it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/gitk b/gitk
index 9be10a4..ba4644f 100755
--- a/gitk
+++ b/gitk
@@ -5196,6 +5196,24 @@ proc rereadrefs {} {
     }
 }
 
+proc listrefs {id} {
+    global idtags idheads idotherrefs
+
+    set x {}
+    if {[info exists idtags($id)]} {
+	set x $idtags($id)
+    }
+    set y {}
+    if {[info exists idheads($id)]} {
+	set y $idheads($id)
+    }
+    set z {}
+    if {[info exists idotherrefs($id)]} {
+	set z $idotherrefs($id)
+    }
+    return [list $x $y $z]
+}
+
 proc showtag {tag isnew} {
     global ctext tagcontents tagids linknum

Paul Mackerras· Jun 11, 2006, 23:35 UTC · re: Junio C Hamano · lore

Re: invalid command name "listrefs"

Junio,

Show 7 quoted lines

> Starting gitk, "File->Reread references" results in an error
> dialog.
> 
> This patch resurrects the procedure from an older version, and it
> seems to work for me, but with the updated code it might be that
> you wanted to use a different mechanism to implement rereadrefs
> procedure -- I dunno.

Thanks for pointing that out. I had removed listrefs in the course of doing some changes that I later dropped; not reinstating listrefs at that point was just an oversight.

Paul.