# invalid command name "listrefs"

2 messages from 2006-06-11 to 2006-06-11. Participants: Junio C Hamano, Paul Mackerras.
Thread: https://gitlist.dev/t/4469

## Junio C Hamano, 2006-06-11 16:50

Subject: invalid command name "listrefs"
Message-ID: <7vu06rfxg8.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7vu06rfxg8.fsf%40assigned-by-dhcp.cox.net

```
Starting gitk, "File->Reread references" results in an error
dialog.

This patch resurrects the procedure from an older version, and it
seems to work for me, but with the updated code it might be that
you wanted to use a different mechanism to implement rereadrefs
procedure -- I dunno.

-- >8 --
gitk: rereadrefs wants listrefs 

The listrefs procedure was removed during the course of
development, but there is still a user of it, so resurrect it.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
diff --git a/gitk b/gitk
index 9be10a4..ba4644f 100755
--- a/gitk
+++ b/gitk
@@ -5196,6 +5196,24 @@ proc rereadrefs {} {
     }
 }
 
+proc listrefs {id} {
+    global idtags idheads idotherrefs
+
+    set x {}
+    if {[info exists idtags($id)]} {
+	set x $idtags($id)
+    }
+    set y {}
+    if {[info exists idheads($id)]} {
+	set y $idheads($id)
+    }
+    set z {}
+    if {[info exists idotherrefs($id)]} {
+	set z $idotherrefs($id)
+    }
+    return [list $x $y $z]
+}
+
 proc showtag {tag isnew} {
     global ctext tagcontents tagids linknum
 

```

## Paul Mackerras, 2006-06-11 23:35

Subject: Re: invalid command name "listrefs"
Message-ID: <17548.43218.342840.246792@cargo.ozlabs.ibm.com>
URL: https://gitlist.dev/e/17548.43218.342840.246792%40cargo.ozlabs.ibm.com
In-Reply-To: <7vu06rfxg8.fsf@assigned-by-dhcp.cox.net>

```
Junio,

> Starting gitk, "File->Reread references" results in an error
> dialog.
> 
> This patch resurrects the procedure from an older version, and it
> seems to work for me, but with the updated code it might be that
> you wanted to use a different mechanism to implement rereadrefs
> procedure -- I dunno.

Thanks for pointing that out.  I had removed listrefs in the course of
doing some changes that I later dropped; not reinstating listrefs at
that point was just an oversight.

Paul.

```