{"thread":{"id":"4469","subject":"invalid command name \"listrefs\"","startedAt":"2006-06-11T16:50:47Z","lastAt":"2006-06-11T23:35:46Z","messageCount":2,"participants":["Junio C Hamano","Paul Mackerras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"21603","messageId":"7vu06rfxg8.fsf@assigned-by-dhcp.cox.net","threadId":"4469","inReplyTo":null,"subject":"invalid command name \"listrefs\"","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-06-11T16:50:47Z","receivedAt":"2006-06-11T16:50:47Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Starting gitk, \"File->Reread references\" results in an error\ndialog.\n\nThis patch resurrects the procedure from an older version, and it\nseems to work for me, but with the updated code it might be that\nyou wanted to use a different mechanism to implement rereadrefs\nprocedure -- I dunno.\n\n-- >8 --\ngitk: rereadrefs wants listrefs \n\nThe listrefs procedure was removed during the course of\ndevelopment, but there is still a user of it, so resurrect it.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\ndiff --git a/gitk b/gitk\nindex 9be10a4..ba4644f 100755\n--- a/gitk\n+++ b/gitk\n@@ -5196,6 +5196,24 @@ proc rereadrefs {} {\n     }\n }\n \n+proc listrefs {id} {\n+    global idtags idheads idotherrefs\n+\n+    set x {}\n+    if {[info exists idtags($id)]} {\n+\tset x $idtags($id)\n+    }\n+    set y {}\n+    if {[info exists idheads($id)]} {\n+\tset y $idheads($id)\n+    }\n+    set z {}\n+    if {[info exists idotherrefs($id)]} {\n+\tset z $idotherrefs($id)\n+    }\n+    return [list $x $y $z]\n+}\n+\n proc showtag {tag isnew} {\n     global ctext tagcontents tagids linknum\n \n"},{"id":"21616","messageId":"17548.43218.342840.246792@cargo.ozlabs.ibm.com","threadId":"4469","inReplyTo":"7vu06rfxg8.fsf@assigned-by-dhcp.cox.net","subject":"Re: invalid command name \"listrefs\"","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2006-06-11T23:35:46Z","receivedAt":"2006-06-11T23:35:46Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Junio,\n\n> Starting gitk, \"File->Reread references\" results in an error\n> dialog.\n> \n> This patch resurrects the procedure from an older version, and it\n> seems to work for me, but with the updated code it might be that\n> you wanted to use a different mechanism to implement rereadrefs\n> procedure -- I dunno.\n\nThanks for pointing that out.  I had removed listrefs in the course of\ndoing some changes that I later dropped; not reinstating listrefs at\nthat point was just an oversight.\n\nPaul.\n"}]}