threads / patch / 43992

patchxdiff: remove unneeded declarations

Subject: [PATCH] xdiff: remove unneeded declarations

## tl;dr

3 messages between Sep 3, 2016 and Sep 7, 2016. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Stefan Beller· Sep 3, 2016, 03:16 UTC · lore
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 xdiff/xemit.c | 9 ---------
 1 file changed, 9 deletions(-)
Show changes to xdiff/xemit.c +0 −9
diff --git a/xdiff/xemit.c b/xdiff/xemit.c
index 49aa16f..b52b4b9 100644
--- a/xdiff/xemit.c
+++ b/xdiff/xemit.c
@@ -22,15 +22,6 @@
 
 #include "xinclude.h"
 
-
-
-
-static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
-static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
-
-
-
-
 static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
 
 	*rec = xdf->recs[ri]->ptr;
-- 
2.10.0.rc2.22.g25cb54d.dirty
Stefan Beller· Sep 6, 2016, 17:57 UTC · re: Stefan Beller · lore

Re: [PATCH] xdiff: remove unneeded declarations

On Fri, Sep 2, 2016 at 8:16 PM, Stefan Beller <sbeller@google.com> wrote:
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  xdiff/xemit.c | 9 ---------
>  1 file changed, 9 deletions(-)

Despite the moved coloring patch moving into a different direction, I think this is still an improvement to the code.

Thanks, Stefan

Show 24 quoted lines
>
> diff --git a/xdiff/xemit.c b/xdiff/xemit.c
> index 49aa16f..b52b4b9 100644
> --- a/xdiff/xemit.c
> +++ b/xdiff/xemit.c
> @@ -22,15 +22,6 @@
>
>  #include "xinclude.h"
>
> -
> -
> -
> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
> -
> -
> -
> -
>  static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
>
>         *rec = xdf->recs[ri]->ptr;
> --
> 2.10.0.rc2.22.g25cb54d.dirty
>
Junio C Hamano· Sep 7, 2016, 16:40 UTC · re: Stefan Beller · lore

Re: [PATCH] xdiff: remove unneeded declarations

Stefan Beller <sbeller@google.com> writes:
Show 25 quoted lines
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  xdiff/xemit.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/xdiff/xemit.c b/xdiff/xemit.c
> index 49aa16f..b52b4b9 100644
> --- a/xdiff/xemit.c
> +++ b/xdiff/xemit.c
> @@ -22,15 +22,6 @@
>  
>  #include "xinclude.h"
>  
> -
> -
> -
> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
> -
> -
> -
> -
>  static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
>  
>  	*rec = xdf->recs[ri]->ptr;
Thanks.

← back to recent threads