{"thread":{"id":"43992","subject":"[PATCH] xdiff: remove unneeded declarations","startedAt":"2016-09-03T03:16:59Z","lastAt":"2016-09-07T16:40:54Z","messageCount":3,"participants":["Stefan Beller","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"300938","messageId":"20160903031648.14465-1-sbeller@google.com","threadId":"43992","inReplyTo":null,"subject":"[PATCH] xdiff: remove unneeded declarations","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-09-03T03:16:48Z","receivedAt":"2016-09-03T03:16:59Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Signed-off-by: Stefan Beller <sbeller@google.com>\n---\n xdiff/xemit.c | 9 ---------\n 1 file changed, 9 deletions(-)\n\ndiff --git a/xdiff/xemit.c b/xdiff/xemit.c\nindex 49aa16f..b52b4b9 100644\n--- a/xdiff/xemit.c\n+++ b/xdiff/xemit.c\n@@ -22,15 +22,6 @@\n \n #include \"xinclude.h\"\n \n-\n-\n-\n-static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);\n-static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);\n-\n-\n-\n-\n static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {\n \n \t*rec = xdf->recs[ri]->ptr;\n-- \n2.10.0.rc2.22.g25cb54d.dirty\n\n"},{"id":"301214","messageId":"CAGZ79kZt5M60xC6w1_12U1M168uJ3MGE2-ikoDx96kzYpfHVug@mail.gmail.com","threadId":"43992","inReplyTo":"20160903031648.14465-1-sbeller@google.com","subject":"Re: [PATCH] xdiff: remove unneeded declarations","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-09-06T17:57:54Z","receivedAt":"2016-09-06T17:58:00Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Fri, Sep 2, 2016 at 8:16 PM, Stefan Beller <sbeller@google.com> wrote:\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n>  xdiff/xemit.c | 9 ---------\n>  1 file changed, 9 deletions(-)\n\nDespite the moved coloring patch moving into a different direction, I\nthink this is still\nan improvement to the code.\n\nThanks,\nStefan\n\n>\n> diff --git a/xdiff/xemit.c b/xdiff/xemit.c\n> index 49aa16f..b52b4b9 100644\n> --- a/xdiff/xemit.c\n> +++ b/xdiff/xemit.c\n> @@ -22,15 +22,6 @@\n>\n>  #include \"xinclude.h\"\n>\n> -\n> -\n> -\n> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);\n> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);\n> -\n> -\n> -\n> -\n>  static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {\n>\n>         *rec = xdf->recs[ri]->ptr;\n> --\n> 2.10.0.rc2.22.g25cb54d.dirty\n>\n"},{"id":"301289","messageId":"xmqq8tv3pssd.fsf@gitster.mtv.corp.google.com","threadId":"43992","inReplyTo":"20160903031648.14465-1-sbeller@google.com","subject":"Re: [PATCH] xdiff: remove unneeded declarations","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-09-07T16:40:34Z","receivedAt":"2016-09-07T16:40:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller <sbeller@google.com> writes:\n\n> Signed-off-by: Stefan Beller <sbeller@google.com>\n> ---\n>  xdiff/xemit.c | 9 ---------\n>  1 file changed, 9 deletions(-)\n>\n> diff --git a/xdiff/xemit.c b/xdiff/xemit.c\n> index 49aa16f..b52b4b9 100644\n> --- a/xdiff/xemit.c\n> +++ b/xdiff/xemit.c\n> @@ -22,15 +22,6 @@\n>  \n>  #include \"xinclude.h\"\n>  \n> -\n> -\n> -\n> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);\n> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);\n> -\n> -\n> -\n> -\n>  static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {\n>  \n>  \t*rec = xdf->recs[ri]->ptr;\n\nThanks.\n"}]}