# [PATCH] xdiff: remove unneeded declarations

3 messages from 2016-09-03 to 2016-09-07. Participants: Stefan Beller, Junio C Hamano.
Thread: https://gitlist.dev/t/43992

## Stefan Beller, 2016-09-03 03:16

Subject: [PATCH] xdiff: remove unneeded declarations
Message-ID: <20160903031648.14465-1-sbeller@google.com>
URL: https://gitlist.dev/e/20160903031648.14465-1-sbeller%40google.com

```
Signed-off-by: Stefan Beller <sbeller@google.com>
---
 xdiff/xemit.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/xdiff/xemit.c b/xdiff/xemit.c
index 49aa16f..b52b4b9 100644
--- a/xdiff/xemit.c
+++ b/xdiff/xemit.c
@@ -22,15 +22,6 @@
 
 #include "xinclude.h"
 
-
-
-
-static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
-static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
-
-
-
-
 static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
 
 	*rec = xdf->recs[ri]->ptr;
-- 
2.10.0.rc2.22.g25cb54d.dirty


```

## Stefan Beller, 2016-09-06 17:57

Subject: Re: [PATCH] xdiff: remove unneeded declarations
Message-ID: <CAGZ79kZt5M60xC6w1_12U1M168uJ3MGE2-ikoDx96kzYpfHVug@mail.gmail.com>
URL: https://gitlist.dev/e/CAGZ79kZt5M60xC6w1_12U1M168uJ3MGE2-ikoDx96kzYpfHVug%40mail.gmail.com
In-Reply-To: <20160903031648.14465-1-sbeller@google.com>

```
On Fri, Sep 2, 2016 at 8:16 PM, Stefan Beller <sbeller@google.com> wrote:
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  xdiff/xemit.c | 9 ---------
>  1 file changed, 9 deletions(-)

Despite the moved coloring patch moving into a different direction, I
think this is still
an improvement to the code.

Thanks,
Stefan

>
> diff --git a/xdiff/xemit.c b/xdiff/xemit.c
> index 49aa16f..b52b4b9 100644
> --- a/xdiff/xemit.c
> +++ b/xdiff/xemit.c
> @@ -22,15 +22,6 @@
>
>  #include "xinclude.h"
>
> -
> -
> -
> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
> -
> -
> -
> -
>  static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
>
>         *rec = xdf->recs[ri]->ptr;
> --
> 2.10.0.rc2.22.g25cb54d.dirty
>

```

## Junio C Hamano, 2016-09-07 16:40

Subject: Re: [PATCH] xdiff: remove unneeded declarations
Message-ID: <xmqq8tv3pssd.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqq8tv3pssd.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <20160903031648.14465-1-sbeller@google.com>

```
Stefan Beller <sbeller@google.com> writes:

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  xdiff/xemit.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/xdiff/xemit.c b/xdiff/xemit.c
> index 49aa16f..b52b4b9 100644
> --- a/xdiff/xemit.c
> +++ b/xdiff/xemit.c
> @@ -22,15 +22,6 @@
>  
>  #include "xinclude.h"
>  
> -
> -
> -
> -static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec);
> -static int xdl_emit_record(xdfile_t *xdf, long ri, char const *pre, xdemitcb_t *ecb);
> -
> -
> -
> -
>  static long xdl_get_rec(xdfile_t *xdf, long ri, char const **rec) {
>  
>  	*rec = xdf->recs[ri]->ptr;

Thanks.

```