threads / patch / 43839

patchsubmodule: mark a file-local symbol as static

Subject: [PATCH] submodule: mark a file-local symbol as static

## tl;dr

2 messages between Aug 14, 2016 and Aug 15, 2016. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Aug 13, 2016, 14:31 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Stefan,

If you need to re-roll your 'sb/submodule-clone-rr' branch, could you please squash this into the relevant patch (commit 7bcd1d17, "clone: recursive and reference option triggers submodule alternates", 11-08-2016).

Thanks!
[What, deja vu? :-D]

ATB, Ramsay Jones

 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to builtin/submodule--helper.c +1 −1
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index c617667..cb0b1d7 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -483,7 +483,7 @@ struct submodule_alternate_setup {
 #define SUBMODULE_ALTERNATE_SETUP_INIT { NULL, \
 	SUBMODULE_ALTERNATE_ERROR_IGNORE, NULL }
 
-int add_possible_reference_from_superproject(
+static int add_possible_reference_from_superproject(
 		struct alternate_object_database *alt, void *sas_cb)
 {
 	struct submodule_alternate_setup *sas = sas_cb;
-- 
2.9.0
Stefan Beller· Aug 15, 2016, 19:07 UTC · re: Ramsay Jones · lore

Re: [PATCH] submodule: mark a file-local symbol as static

On Sat, Aug 13, 2016 at 7:31 AM, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

Show 12 quoted lines
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Stefan,
>
> If you need to re-roll your 'sb/submodule-clone-rr' branch, could
> you please squash this into the relevant patch (commit 7bcd1d17,
> "clone: recursive and reference option triggers submodule alternates",
> 11-08-2016).
>
> Thanks!
Thanks,
will be fixed in a reroll.

← back to recent threads