{"thread":{"id":"43839","subject":"[PATCH] submodule: mark a file-local symbol as static","startedAt":"2016-08-14T12:04:40Z","lastAt":"2016-08-15T19:07:38Z","messageCount":2,"participants":["Ramsay Jones","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"299271","messageId":"a44793c6-6510-9b62-d5f4-60324a062164@ramsayjones.plus.com","threadId":"43839","inReplyTo":null,"subject":"[PATCH] submodule: mark a file-local symbol as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-08-13T14:31:24Z","receivedAt":"2016-08-14T12:04:40Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Stefan,\n\nIf you need to re-roll your 'sb/submodule-clone-rr' branch, could\nyou please squash this into the relevant patch (commit 7bcd1d17,\n\"clone: recursive and reference option triggers submodule alternates\",\n11-08-2016).\n\nThanks!\n\n[What, deja vu? :-D]\n\nATB,\nRamsay Jones\n\n builtin/submodule--helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c\nindex c617667..cb0b1d7 100644\n--- a/builtin/submodule--helper.c\n+++ b/builtin/submodule--helper.c\n@@ -483,7 +483,7 @@ struct submodule_alternate_setup {\n #define SUBMODULE_ALTERNATE_SETUP_INIT { NULL, \\\n \tSUBMODULE_ALTERNATE_ERROR_IGNORE, NULL }\n \n-int add_possible_reference_from_superproject(\n+static int add_possible_reference_from_superproject(\n \t\tstruct alternate_object_database *alt, void *sas_cb)\n {\n \tstruct submodule_alternate_setup *sas = sas_cb;\n-- \n2.9.0\n"},{"id":"299378","messageId":"CAGZ79kbsyjgPnZuCBrivYUN-tYoDNkT9VKrwXC8=C9UoorCtLw@mail.gmail.com","threadId":"43839","inReplyTo":"a44793c6-6510-9b62-d5f4-60324a062164@ramsayjones.plus.com","subject":"Re: [PATCH] submodule: mark a file-local symbol as static","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2016-08-15T19:07:29Z","receivedAt":"2016-08-15T19:07:38Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Sat, Aug 13, 2016 at 7:31 AM, Ramsay Jones\n<ramsay@ramsayjones.plus.com> wrote:\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Stefan,\n>\n> If you need to re-roll your 'sb/submodule-clone-rr' branch, could\n> you please squash this into the relevant patch (commit 7bcd1d17,\n> \"clone: recursive and reference option triggers submodule alternates\",\n> 11-08-2016).\n>\n> Thanks!\n\nThanks,\n\nwill be fixed in a reroll.\n"}]}